Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: Update purchase page layout #84941

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Conversation

kangzj
Copy link
Contributor

@kangzj kangzj commented Dec 7, 2023

Related to #84885

Proposed Changes

  • Wider card left according to design
  • Switch price fully on feature flag
  • Adjust button text and margin

Testing Instructions

  • Open Calypso Live Branch
  • Open /stats/purchase/{site-slug}?flags=stats/tier-upgrade-slider&from=calypso-stats-upgrade-notice&productType=commercial
  • Ensure it looks like the following
image
  • Open /stats/purchase/{site-slug}?flags=stats/tier-upgrade-slider&from=calypso-stats-upgrade-notice&productType=personal
  • Ensure it looks like the following
image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@kangzj kangzj added the [Feature] Stats Everything related to our analytics product at /stats/ label Dec 7, 2023
@kangzj kangzj requested review from grzegorz-cp and a team December 7, 2023 01:00
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 7, 2023
Copy link

github-actions bot commented Dec 7, 2023

@kangzj kangzj marked this pull request as ready for review December 7, 2023 01:01
@kangzj kangzj self-assigned this Dec 7, 2023
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/purchase-page-layout on your sandbox.

@kangzj kangzj added the Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change. label Dec 7, 2023
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~4 bytes added 📈 [gzipped])

name                                              parsed_size           gzip_size
async-load-calypso-my-sites-stats-stats-purchase        +27 B  (+0.0%)       +4 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@grzegorz-cp grzegorz-cp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@grzegorz-cp grzegorz-cp merged commit ea501bc into trunk Dec 7, 2023
17 of 18 checks passed
@grzegorz-cp grzegorz-cp deleted the update/purchase-page-layout branch December 7, 2023 04:42
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 7, 2023
cpapazoglou pushed a commit that referenced this pull request Dec 11, 2023
* layout adjustments

* switch fully on flag and adjust margins
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Stats Everything related to our analytics product at /stats/ Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants