Plans 2023: Split and export the individual grids (FeaturesGrid, ComparisonGrid) - take 2

[chriskmnds]

Related to #78266
Takes over #80915

Proposed Changes

Converts the main package component plans-grid into an index of individual parts, exported and assembled at the consuming end. We effectively now export FeaturesGrid and ComparisonGrid separately, and a single gridPlans prop in place of gridPlansForFeauresGrid, etc.

Additional Notes

• There is some repetition in the "wrappers" exported from the main index file, and that's intentional. All of that will gradually shrink to simply reflected imports as we clean up more dependencies i.e. there will be no need for these wrappers altogether.
• The ComparisonGrid carries its title along, which is something incredibly small that we can handle in a follow-up.
• A props refactor should also happen on top of this PR. A separate issue exists: Plans 2023: Revise and split the grid component props #82335
• Some performance concerns are being handled in a separate PR. For the most part, things should be functioning reasonably.

Testing Instructions

• Confirm /start and /plans/[ paid | free ] render as before
• Confirm tailored flows (newsletter, wooexpress) work as before
• Confirm plan-term toggle works correctly

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-82427

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-82427&env=jetpack

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~52 bytes removed 📉 [gzipped])

name                  parsed_size           gzip_size
update-design-flow         +765 B  (+0.1%)      -52 B  (-0.0%)
plugins                    +765 B  (+0.0%)      -52 B  (-0.0%)
plans                      +765 B  (+0.1%)      -52 B  (-0.0%)
link-in-bio-tld-flow       +765 B  (+0.0%)      -52 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~52 bytes removed 📉 [gzipped])

name                                             parsed_size           gzip_size
async-load-signup-steps-plans-theme-preselected       +765 B  (+0.2%)      -52 B  (-0.0%)
async-load-signup-steps-plans                         +765 B  (+0.2%)      -52 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[chriskmnds]

This we ought to address in a bit of immediate follow-up. We may consider splitting these props across several pieces, and updating the respective READMEs while at it, possibly:

1. ContextProps (not exported) all the props that pertain to things added to the context
2. SharedPlansGridProps (not exported) all the props that are shared between the FeaturesGrid and ComparisonGrid (et al)
3. ComparisonGridProps
4. FeaturesGridProps

[chriskmnds]

Created a separate issue for this #82335

[chriskmnds]

Some performance concerns are being handled in a separate PR. For the most part, things should be functioning reasonably.

Performance optimisations addressed in #82403

[southp]

Following the test plan I previously wrote it all works as expected :) On top of that test plan, I've also tried out the storage add-on dropdown, term toggle, plan picker of the comparison grid, and the mobile resolutions. Oh my, we really should compile a QA guide or something 🙃

I do notice there are some things broken in the comparison grid in /plans, e.g. the styling of the Free plan is missing, the tooltips are flashing, "show features" requires 3 clicks to be expanded. However, those also happen in production so should be tracked and resolved separately from this 🚢

[chriskmnds]

Thanks @southp .

I do notice there are some things broken in the comparison grid in /plans, e.g. the styling of the Free plan is missing, the tooltips are flashing, "show features" requires 3 clicks to be expanded. However, those also happen in production so should be tracked and resolved separately from this 🚢

I don't notice these in the live image 🤔

Do you mind confirming and we can create a few issues for them?

"show features" requires 3 clicks to be expanded.

This sounds pretty severe. Do you mean the "show all features" toggle in the mobile cards?