Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg v19.6.0-rc.2 Removes getCanvasMode() #95960

Closed
holdercp opened this issue Oct 31, 2024 · 1 comment
Closed

Gutenberg v19.6.0-rc.2 Removes getCanvasMode() #95960

holdercp opened this issue Oct 31, 2024 · 1 comment
Labels
Needs triage Ticket needs to be triaged [Platform] Atomic [Platform] Simple [Pri] Normal Schedule for the next available opportuinity. [Status] Fix Inbound Use when a fix is in unreleased component [Type] Bug

Comments

@holdercp
Copy link
Contributor

holdercp commented Oct 31, 2024

Quick summary

This is a defect discovered during testing the upcoming Gutenberg 19.6.0 release. It is not live.

The Gutenberg v19.6.0-rc.2 release removes the getCanvasMode() API in WordPress/gutenberg#66213 from the edit-site store. Several Calypso apps are using this API and are now unable to load with this GB version installed.

The following Calypso apps should be updated to determine the canvas state from the URL params as suggested in the GB PR:

  • help-center
  • wpcom-block-editor

Using the URL for this state is compatible with older GB releases so this can be deployed before v19.6.0 lands.

Related to Automattic/jetpack#39997

Steps to reproduce

  1. Install GB v19.6.0-rc.2 on a site
  2. Install a Full Site Edit theme
  3. Navigate to Appearance -> Editor
  4. Check console logs and notice errors relating to the help-center, wpcom-block-editor, and the Jetpack wpcom-block-editor-nux plugins
  5. Notice the help center icon is missing
  6. Click into the canvas to edit
  7. Notice the errors in the UI

What you expected to happen

The mentioned plugins load as normal.

What actually happened

  • Missing help icon
  • Visible UI errors
  • Console errors

Image

Impact

All

Available workarounds?

There is no user impact

If the above answer is "Yes...", outline the workaround.

No response

Platform (Simple and/or Atomic)

Simple, Atomic

Logs or notes

No response

@obenland
Copy link
Member

obenland commented Nov 4, 2024

@holdercp Can this be closed now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs triage Ticket needs to be triaged [Platform] Atomic [Platform] Simple [Pri] Normal Schedule for the next available opportuinity. [Status] Fix Inbound Use when a fix is in unreleased component [Type] Bug
Development

No branches or pull requests

2 participants