Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wpcom-block-editor: Support getting the canvas mode from the query string after GB 19.6 #95979

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

arthur791004
Copy link
Contributor

@arthur791004 arthur791004 commented Nov 1, 2024

Related to #95960

Proposed Changes

  • Support getting the canvas mode from the query string because the getCanvasMode selector is removed after GB 19.6

Why are these changes being made?

  • The getCanvasMode selector is removed after GB 19.6 and causes the error.

Testing Instructions

  • Sandbox widgets.wp.com
  • Apply changes to your site by either one of below
    • Run yarn dev --sync
    • Run install-plugin.sh wpcom-block-editor fix/wpcom-block-editor-canvas-mode on your sandbox
  • Go to Theme Showcase on your free site
  • Pick any paid block theme
  • Preview the theme in the editor
  • Make sure to disable the cache of https://widgets.wp.com/wpcom-block-editor/wpcom.editor.min.js
  • Make sure you can see the upgrade notice of the live preview on both view and edit mode

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@arthur791004 arthur791004 self-assigned this Nov 1, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

matticbot commented Nov 1, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/wpcom-block-editor-canvas-mode on your sandbox.

@arthur791004 arthur791004 requested a review from a team November 1, 2024 06:16
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 1, 2024
Copy link
Contributor

@fushar fushar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working great, thanks for the patch!

@arthur791004 arthur791004 merged commit 3427a68 into trunk Nov 1, 2024
15 checks passed
@arthur791004 arthur791004 deleted the fix/wpcom-block-editor-canvas-mode branch November 1, 2024 08:59
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants