You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
These are being imported into lib/plans/features-list which is being migrated to @automattic/calypso-products for importing and using outside of the Calypso environment.
How
One idea would be to create a @automattic/calypso-assets package (or something of this nature) and initiate the package with migrating SupportIcon and Theme2Image there. Moving along, we could be migrating more things until the entirety of /client/assets migrates.
Other options:
SupportIcon: This could fit into @automattic/components/icons
Theme2Image: This is a jpg that's only used in features-list. It could fit into @automattic/calypso-products/assets (new folder)
MaterialIcon: This could fit straight into @automattic/components (similar to the WP logo there)
The text was updated successfully, but these errors were encountered:
chriskmnds
changed the title
Plans Next: Migrate assets/svgs imported in features-list to @automattic/components
Plans Next: Migrate assets/svgs imported in features-list to packages
Mar 8, 2024
If you really insist, you can create a new assets package, but for a couple of assets, it feels like overkill. What you suggested in "other options" seems OK to me and that's what I'd likely prefer to do.
If you really insist, you can create a new assets package, but for a couple of assets, it feels like overkill. What you suggested in "other options" seems OK to me and that's what I'd likely prefer to do.
Thanks @tyxla. It makes sense. "other options" were also my first/immediate take on this, so will go with that and avoid a new package
What
Part of addressing #79004
Migrate the following icons or images into a publicly accessible package:
SupportIcon
: from client/assets/images/onboarding/support.svg.Theme2Image
: from client/assets/images/onboarding/theme-2.jpg.MaterialIcon
: from client/components/material-icon.Why
These are being imported into
lib/plans/features-list
which is being migrated to@automattic/calypso-products
for importing and using outside of the Calypso environment.How
One idea would be to create a
@automattic/calypso-assets
package (or something of this nature) and initiate the package with migratingSupportIcon
andTheme2Image
there. Moving along, we could be migrating more things until the entirety of/client/assets
migrates.Other options:
@automattic/components/icons
features-list
. It could fit into@automattic/calypso-products/assets
(new folder)@automattic/components
(similar to the WP logo there)The text was updated successfully, but these errors were encountered: