Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans Next: Migrate the Features list/metadata to @automattic/calypso-products #79004

Closed
3 of 4 tasks
chriskmnds opened this issue Jul 5, 2023 · 3 comments · Fixed by #88186
Closed
3 of 4 tasks

Plans Next: Migrate the Features list/metadata to @automattic/calypso-products #79004

chriskmnds opened this issue Jul 5, 2023 · 3 comments · Fixed by #88186

Comments

@chriskmnds
Copy link
Contributor

chriskmnds commented Jul 5, 2023

This is part of uncoupling the plans-grid components for enabling and exploring use outside of Calypso.

We have so far worked around the FEATURES_LIST definition living locally in Calypso by passing it into the components as a prop. However, that only allowed us to migrate the grid components to a package. We need to address the features list definition of living locally now. We cannot possibly use the plans-grid package in an external environment without the list of features.

It's not a straight-up migration as FEATURES_LIST has a few local dependencies - icons, ExternalLinkWithTracking component, etc. We will piece-meal the migration. Similarly to the AddOns metadata migration (#81374), we have created an exploratory PR (#88186) with TODOs and a list of tasks below.

Tasks

Preview Give feedback
  1. Plans: NPM essential
    chriskmnds
  2. Plans: NPM essential
    chriskmnds
  3. Plans: NPM essential
    oswian
  4. Plans: NPM essential
    chriskmnds
@chriskmnds
Copy link
Contributor Author

Handling a partial solution to uncouple plans-features-2023-grid in #79733. Specifically the following:

as a more realistic/faster alternative we can consider passing features-list as a prop and localise the getPlanFeaturesObject method in plans-features-2023-grid

cc @southp (we'll still need these ported into calypso-products, but with #79733 it will no longer be a blocker to package extraction

@southp
Copy link
Contributor

southp commented Jul 24, 2023

Thansk for the heads up. Good to know that you've identified a way around it :)
Also cc @jdc91 here since I've recommended him to look into this issue the other day.

@chriskmnds chriskmnds removed their assignment Sep 12, 2023
@chriskmnds chriskmnds self-assigned this Mar 5, 2024
@chriskmnds chriskmnds changed the title Plans 2023 (NPM essential): Migrate features-list and getPlanFeaturesObject to data store (or other workaround) Plans Next: Migrate the Features list/metadata to @automattic/calypso-products Mar 5, 2024
@chriskmnds
Copy link
Contributor Author

Update: Updated the description and added a list of tasks to handle this migration. There's a bit to do, although it will also contribute to the overall hygiene e.g. #88183 will be cleaning up more than just serving the Plans NPM migration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants