Plugins update manager: Add weekday to track events (#88843)

Automattic · Mar 25, 2024 · 4b68c31 · 4b68c31
1 parent 922803b
commit 4b68c31
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 5 deletions.
diff --git a/client/blocks/plugins-update-manager/schedule-create.tsx b/client/blocks/plugins-update-manager/schedule-create.tsx
@@ -68,6 +68,7 @@ export const ScheduleCreate = ( props: Props ) => {
 			frequency: params.frequency,
 			plugins_number: params.plugins.length,
 			hours: params.hours,
+			weekday: params.weekday,
 		} );
 
 		createMonitor();

diff --git a/client/blocks/plugins-update-manager/schedule-edit.tsx b/client/blocks/plugins-update-manager/schedule-edit.tsx
@@ -58,6 +58,7 @@ export const ScheduleEdit = ( props: Props ) => {
 			frequency: params.frequency,
 			plugins_number: params.plugins.length,
 			hours: params.hours,
+			weekday: params.weekday,
 		} );
 
 		setSyncError( '' );

diff --git a/client/blocks/plugins-update-manager/schedule-form.tsx b/client/blocks/plugins-update-manager/schedule-form.tsx
@@ -51,13 +51,15 @@ export const ScheduleForm = ( props: Props ) => {
 	const [ fieldTouched, setFieldTouched ] = useState< Record< string, boolean > >( {} );
 
 	const serverSyncCallbacks = {
-		onSuccess: () =>
-			onSyncSuccess &&
-			onSyncSuccess( {
+		onSuccess: () => {
+			const date = new Date( timestamp * 1000 );
+			onSyncSuccess?.( {
 				plugins: selectedPlugins,
 				frequency,
-				hours: new Date( timestamp * 1000 ).getHours(),
-			} ),
+				hours: date.getHours(),
+				weekday: frequency === 'weekly' ? date.getDay() : undefined,
+			} );
+		},
 		onError: ( e: Error ) => onSyncError && onSyncError( e.message ),
 	};
 	const { createUpdateSchedule } = useCreateUpdateScheduleMutation( siteSlug, serverSyncCallbacks );

diff --git a/client/blocks/plugins-update-manager/types.ts b/client/blocks/plugins-update-manager/types.ts
@@ -2,4 +2,5 @@ export type SyncSuccessParams = {
 	plugins: string[];
 	frequency: 'daily' | 'weekly';
 	hours: number;
+	weekday?: number;
 };