Preserve whitespace inside pre elements when federating content #2595
+76
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2592
Proposed changes:
Sanitize::strip_whitespace()method that strips newlines, carriage returns, and tabs from content while preserving them inside<pre>elements.Shortcodes::content()andPost::get_content()to use the new sanitization method.Code blocks in federated posts were losing their newline characters, making them unreadable. The fix uses a regex with
preg_replace_callbackto preserve whitespace inside<pre>tags while stripping it from the rest of the content.Other information:
Testing instructions:
/wp-json/activitypub/1.0/posts/{id})Changelog entry
Changelog Entry Details
Significance
Type
Message
Preserve newlines inside pre elements when federating content.