Wrap blocked domains and keywords in collapsible details element #2591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR improves the user experience in the ActivityPub moderation settings by making blocked domains and keywords lists collapsible. Users can now see at a glance how many items are blocked without being overwhelmed by long lists, while still having easy access to the full list when needed.
Key Changes:
- Wrapped blocked domains and keywords tables in HTML
<details>elements with summary text showing the count - Added count display using WordPress i18n plural functions
- Kept add forms visible outside collapsible sections to maintain easy access
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| includes/wp-admin/class-settings-fields.php | Added collapsible <details> wrapper with count display for both blocked domains and keywords tables |
| .github/changelog/2591-from-description | Added changelog entry documenting the UI improvement |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pfefferle
reviewed
Dec 5, 2025
Move the inline styles for the collapsible details/summary elements to activitypub-admin.css instead of using inline styles in PHP.
obenland
force-pushed
the
update/collapsible-moderation-tables
branch
from
4d67dae to
6205b3c
Compare
Member
|
I generally like the idea, but it is still a bit glitchy.
|
- Always render <details> wrapper structure (even when empty) with data-type attribute - Add <tbody> wrapper for proper striped table styling - Update JavaScript to work with collapsible structure and update summary counts dynamically - Use wp.i18n._n() for proper pluralization instead of localized strings - Add wp-i18n dependency and wp_set_script_translations() - Extract duplicated validation/message code into helper functions - Add JSDoc comments for better IDE support
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Use jQuery's element construction with attributes object and .text() instead of string concatenation when inserting user-controlled values into the DOM. This prevents malicious input from being executed.
Member
Author
|
@pfefferle This should behave less glitchy now. |
pfefferle
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
<details>elements.Other information:
Testing instructions:
Changelog entry
Changelog Entry Details
Significance
Type
Message
Wrap blocked domains and keywords tables in collapsible details element.