Refactor: Reorganize integration loader and Stream integration #2383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reorganize integrations in load.php in alphabetical order - Move Stream integration into dedicated stream/ folder structure - Create Stream wrapper class to encapsulate Stream-related functionality - Move Stream_Connector class to stream/class-connector.php with updated namespace - Move stream registration and filter functions into Stream class methods - Consolidate BuddyPress initialization with other integrations - Update test file to use new Stream\Connector namespace
github-actions
bot
added
[Focus] Compatibility
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Stream plugin integration by reorganizing code structure and improving namespace organization. The main changes move the Stream Connector into its own namespace and create a dedicated Stream integration class to handle registration logic.
- Renamed
Stream_Connectorclass toConnectorand moved it toActivitypub\Integration\Streamnamespace - Created new
Streamclass to centralize Stream plugin integration logic (connector registration and post type exclusion) - Updated all references in test files and integration loader to use the new namespace and class names
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| integration/stream/class-stream.php | New file introducing the Stream class that handles Stream plugin integration initialization, connector registration, and post type exclusion |
| integration/stream/class-connector.php | Renamed from Stream_Connector to Connector, moved to Activitypub\Integration\Stream namespace, and added consistent function escaping with backslashes |
| tests/phpunit/tests/integration/class-test-stream-connector.php | Updated all class references and imports to use the new Activitypub\Integration\Stream\Connector namespace and updated @covers annotations to reference the new Stream::register_connector method |
| integration/load.php | Refactored to call Stream\Stream::init() instead of standalone functions, and reorganized integration initialization order alphabetically |
Comments suppressed due to low confidence (1)
integration/stream/class-connector.php:224
- Missing backslash for global function call. The function
url_to_commentidshould be prefixed with\for consistency with other global function calls in this file (like\url_to_postidon line 216 and\get_commenton line 226).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Move BuddyPress hook registration outside of plugin_init() to ensure it's registered before bp_include fires. BuddyPress fires bp_include on plugins_loaded:8, so registering it in plugin_init() (which runs at plugins_loaded:10) would be too late.
|
Very much so :) It looks like GitHub Action Bot dismissed your review |
pfefferle
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
load.phpin alphabetical order for easier navigationstream/folder structure to compartmentalize related codeActivitypub\IntegrationtoActivitypub\Integration\Streamplugin_init()Other information:
Testing instructions:
npm run test:unit:phpChangelog entry
Changelog Entry Details
Significance
Type
Message
Reorganize integration loader and move Stream integration into dedicated folder structure.