Type safety for IPC messages #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nightnei
approved these changes
Feb 7, 2025
src/index.ts
Outdated
| @@ -14,6 +14,7 @@ import { __ } from '@wordpress/i18n'; | |||
| import packageJson from '../package.json'; | |||
| import { PROTOCOL_PREFIX } from './constants'; | |||
| import * as ipcHandlers from './ipc-handlers'; | |||
| import { sendIpcEventToRenderer } from './ipc-utils'; | |||
There was a problem hiding this comment.
unused
Suggested change
| import { sendIpcEventToRenderer } from './ipc-utils'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
This PR adds type definitions for the IPC messages used in the app.
useIpcListenernow checks the type and automatically senses the callback argument types. I've also addedsendIpcEventToRendererandsendIpcEventToRendererWithWindowas type-safe wrappers aroundBrowserWindow.webContents.send.Testing Instructions
Code review and some light smoke testing should suffice.
Pre-merge Checklist