fix: fix watch for child theme CSS

[laurelfulford]

All Submissions:

• Have you followed the Newspack Contributing guideline?
• Does your code follow the WordPress' coding standards and VIP Go coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

This PR makes sure the child theme SCSS is updated when running npm run watch, not just npm run build.

How to test the changes in this Pull Request:

1. Run npm run watch.
2. Make an obvious change in one of the child theme SCSS files (like body { background: red; }
3. Note the CSS doesn't get applied to the generated CSS
4. Apply this PR
5. Repeat steps 1-3 and confirm the CSS changes are generated with watch.

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

[Copilot]

Pull request overview

This PR fixes an issue where child theme SCSS files were not being watched and recompiled during development when using npm run watch. Previously, only the parent theme's SCSS files were being watched. The fix explicitly adds watch paths for all five child themes (sacha, scott, nelson, katharine, and joseph).

Changes:

• Extended the chokidar watch configuration to include sass directories for all child themes

Comments suppressed due to low confidence (2)

scripts/compile-scss.js:231

• The watch configuration is missing the tribe-events directories that also contain SCSS files. Looking at the SASS_STYLESHEETS array (lines 136-137, 155-156, 169-170, 183-184, 197-198, 211-212), each child theme and the parent theme have tribe-events directories with SCSS files that need to be compiled. These directories should also be watched for changes to ensure their SCSS files are recompiled during development.

	chokidar.watch( [
		'newspack-theme/sass/**/*.scss',
		'newspack-sacha/sass/**/*.scss',
		'newspack-scott/sass/**/*.scss',
		'newspack-nelson/sass/**/*.scss',
		'newspack-katharine/sass/**/*.scss',
		'newspack-joseph/sass/**/*.scss',
	] ).on( 'change', path => {

scripts/compile-scss.js:231

• The hardcoded list of watch paths creates a maintainability issue. Each time a new child theme is added, developers need to remember to update this watch array. Consider deriving the watch paths from the SASS_STYLESHEETS array or using a configuration constant that defines child themes in one place. This would ensure the watch functionality stays in sync with the build configuration and reduce the chance of missing paths when new child themes are added.

	chokidar.watch( [
		'newspack-theme/sass/**/*.scss',
		'newspack-sacha/sass/**/*.scss',
		'newspack-scott/sass/**/*.scss',
		'newspack-nelson/sass/**/*.scss',
		'newspack-katharine/sass/**/*.scss',
		'newspack-joseph/sass/**/*.scss',
	] ).on( 'change', path => {

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[laurelfulford]

Thanks @miguelpeixe! 🙌

[github-actions]

Hey @laurelfulford, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

[github-actions]

🎉 This PR is included in version 2.19.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀