Merged
Conversation
6 tasks
rbcorrales
requested changes
Jan 26, 2026
Member
rbcorrales
left a comment
rbcorrales
left a comment
There was a problem hiding this comment.
Looks good! Just a few minor comments and possible improvements.
There was a problem hiding this comment.
Pull request overview
This pull request refactors the CI/CD infrastructure from CircleCI to GitHub Actions, replacing the CircleCI orb with reusable GitHub Actions workflows.
Changes:
- Removed all CircleCI configuration files (orb definitions, jobs, executors, commands, and .circleci/config.yml)
- Added 11 reusable GitHub Actions workflow files for PHP/JS testing, linting, building, releasing, documentation generation, and i18n
- Updated scripts/release.js and post-release.sh to use GitHub Actions environment variables instead of CircleCI variables
Reviewed changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated 17 comments.
Show a summary per file
| File | Description |
|---|---|
| src/jobs/*.yml | Removed CircleCI job definitions for test-php, test-js, lint-php, lint-js-scss, i18n, generate-docs, check-typescript, build, build-distributable, release, and post-release |
| src/executors/*.yml | Removed CircleCI executor definitions |
| src/commands/*.yml | Removed CircleCI command definitions |
| src/@orb.yml | Removed CircleCI orb configuration |
| .circleci/config.yml | Removed main CircleCI configuration file |
| .github/workflows/reusable-test-php.yml | Added reusable workflow for PHP testing with PHPUnit and Codecov integration |
| .github/workflows/reusable-test-js.yml | Added reusable workflow for JavaScript testing |
| .github/workflows/reusable-release.yml | Added reusable workflow for creating releases with semantic-release |
| .github/workflows/reusable-post-release.yml | Added reusable workflow for post-release branch management |
| .github/workflows/reusable-lint-php.yml | Added reusable workflow for PHP linting with PHPCS |
| .github/workflows/reusable-lint-js-scss.yml | Added reusable workflow for JS/SCSS linting |
| .github/workflows/reusable-i18n.yml | Added reusable workflow for translation file generation |
| .github/workflows/reusable-generate-docs.yml | Added reusable workflow for PHPDoc generation |
| .github/workflows/reusable-check-typescript.yml | Added reusable workflow for TypeScript validation |
| .github/workflows/reusable-build.yml | Added reusable workflow for installing Node dependencies |
| .github/workflows/reusable-build-distributable.yml | Added reusable workflow for building distributable archives |
| .github/workflows/release.yml | Added release workflow for the newspack-scripts repository itself |
| scripts/release.js | Updated to use GITHUB_REPOSITORY environment variable and disabled PR comments temporarily |
| post-release.sh | Updated git push URLs to use GITHUB_REPOSITORY environment variable |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…omattic/newspack-scripts into refactor/deprecate-circle-ci
…reusable-release workflow
rbcorrales
approved these changes
Jan 27, 2026
github-actions
bot
added
[Status] Approved
and removed
[Status] Needs Changes or Feedback
labels
miguelpeixe
changed the title
|
🎉 This PR is included in version 5.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements our automated workflows in Github Actions, replacing the CircleCI integration.
This should be tested in each repo before merging:
For now, repos should reference this branch. After tests are complete and this is merged, we should remove the branch reference to rely on the default branch. E.g.:
Automattic/newspack-scripts/.github/workflows/reusable-build.yml@refactor/deprecate-circle-ci