Closed
Conversation
Contributor
|
Should we just merge this and let it run on other repos? |
Contributor
Author
|
Well, actually -> https://make.wordpress.org/core/2023/08/21/wordpresscs-3-0-0-is-now-available At some point I think we can upgrade and it should work fine with php 8 |
Contributor
|
@leogermani looks like phpunit is still working well as of #219. Do we still need to update anything on the PHP testing side? |
Contributor
Author
I don't really remember what this was about but I guess it's not relevant anymore. We have been running php tests in all repos just fine... |
Contributor
|
Closing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Run PHPCS on PHP 7.4 to avoid Fatal errors. See WordPress/WordPress-Coding-Standards@7cd46be
How to test the changes in this Pull Request:
Other information: