fix: use correct is_enabled method#4564
Merged
chickenn00dle merged 1 commit intotrunkfrom Mar 13, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a fatal error in Reader Activation (Audience Management) settings retrieval by using the correct integration-enabled check for the ESP integration, aligning with the integrations framework added in #4541.
Changes:
- Replace an instance
is_enabled()call on the ESP integration withReader_Activation\Integrations::is_enabled( 'esp' )when resolving thesync_espsetting.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
leogermani
approved these changes
Mar 13, 2026
|
Hey @chickenn00dle, good job getting this PR merged! 🎉 Now, the Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label. If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label. Thank you! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This fixes a fatal that resulted in calling the incorrect
is_enabledmethod in #4541How to test the changes in this Pull Request:
Other information: