Skip to content

fix: use correct is_enabled method#4564

Merged
chickenn00dle merged 1 commit intotrunkfrom
fix/integrations-fatal-undefined-method
Mar 13, 2026
Merged

fix: use correct is_enabled method#4564
chickenn00dle merged 1 commit intotrunkfrom
fix/integrations-fatal-undefined-method

Conversation

@chickenn00dle
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This fixes a fatal that resulted in calling the incorrect is_enabled method in #4541

How to test the changes in this Pull Request:

  1. Visit Audience Management
  2. Verify you don't get a fatal

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@chickenn00dle chickenn00dle marked this pull request as ready for review March 13, 2026 18:08
@chickenn00dle chickenn00dle requested a review from a team as a code owner March 13, 2026 18:08
Copilot AI review requested due to automatic review settings March 13, 2026 18:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a fatal error in Reader Activation (Audience Management) settings retrieval by using the correct integration-enabled check for the ESP integration, aligning with the integrations framework added in #4541.

Changes:

  • Replace an instance is_enabled() call on the ESP integration with Reader_Activation\Integrations::is_enabled( 'esp' ) when resolving the sync_esp setting.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions github-actions bot added the [Status] Approved The pull request has been reviewed and is ready to merge label Mar 13, 2026
@chickenn00dle chickenn00dle merged commit 6396e41 into trunk Mar 13, 2026
13 checks passed
@chickenn00dle chickenn00dle deleted the fix/integrations-fatal-undefined-method branch March 13, 2026 18:18
@github-actions
Copy link

Hey @chickenn00dle, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Status] Approved The pull request has been reviewed and is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants