-
Notifications
You must be signed in to change notification settings - Fork 57
feat(author-profile-social): add support for colors, block spacing, brand style #4509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thomasguillot
wants to merge
54
commits into
trunk
Choose a base branch
from
update/author-profile-social
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
54 commits
Select commit
Hold shift + click to select a range
2b76be5
fix(avatar): show placeholder for text-only custom bylines in editor
rbcorrales 3abcd69
feat(avatar): support as nested profile block content
rbcorrales 8e3903c
fix(avatar): resolve guest author avatars in editor (#4460)
rbcorrales cf87cac
perf(avatar): register enriched newspack_author_info REST field
rbcorrales ed5a86b
fix(avatar): resolve context at render time and debounce image fetch
rbcorrales 2e2710e
fix(avatar): respect avatarHideDefault and resolve at correct size
rbcorrales dd8de18
fix(avatar): increase image fetch debounce
rbcorrales ddfc1f8
feat(avatar): render default gravatar in nested mode fallback
rbcorrales 9aee3ed
feat(blocks): add social blocks with shared circular button mixin
rbcorrales e8203d6
fix(author-profile-social): fix spacing and remove duplicate asset en…
rbcorrales 43edb25
fix(avatar): add missing useDefaultAvatar mock in edit tests
rbcorrales 6fb8489
fix(i18n): use correct text domain in social blocks
rbcorrales f3b945a
fix(a11y): add accessible labels to social link blocks
rbcorrales 6645402
fix(author-social-link): sanitize REST API SVGs with safeHTML
rbcorrales f26814f
fix(author-social): pass icon size via block context
rbcorrales f5bcfdc
refactor(author-profile-social): replace wp globals with imports
rbcorrales 24e442e
fix(avatar): remove double escaping of author name
rbcorrales 25b9ba4
fix(use-coauthors): cache negative avatar lookup results
rbcorrales 1c06d5f
fix(avatar): remove double escaping in standalone render path
rbcorrales 455ea09
fix(author-social): respect saved inner blocks on frontend
rbcorrales 6fc7714
fix(social-button): add hex fallbacks for theme color tokens
rbcorrales 3d1fa9a
refactor(avatar): extract shared render_avatar_image helper
rbcorrales 2373555
fix(author-social): remove unused website service
rbcorrales bf523ce
fix(social-icons): align myspace, soundcloud, wikipedia SVGs with theme
rbcorrales 9339795
refactor(social-icons): make plugin the canonical SVG source
rbcorrales 4e3a5ff
refactor(social-icons): deduplicate SVGs into shared class constant
rbcorrales 7b82e97
fix(avatar): adapt overlap mask cutout to match border-radius
rbcorrales ef89878
refactor(blocks): modularize avatar, deduplicate context, add types
rbcorrales 4ccbdb2
perf(blocks): fix useSelect memoization warnings and add apiVersion
rbcorrales 0c9c6d3
fix(bylines): add missing ToggleControl deprecation prop
rbcorrales 6e546c3
fix(test): use WP_Block instead of stdClass in avatar tests
rbcorrales 9858470
feat(social-icons): add REST endpoint for SVG icon map
rbcorrales bb3b3f0
feat(avatar): extract overlap mask constants and adjust mask radius
rbcorrales d2a93eb
fix(social): use full service list for contextual auto-populate
rbcorrales ceb63f2
feat(author-social-link): add service label as block title
thomasguillot fa917a2
feat(author-profile-social): add padding and margin support
thomasguillot 5325de2
feat: update reset link toolbar
thomasguillot 620319a
fix(author-profile-social): remove duplicate wrapper class
rbcorrales 0f439e7
refactor(avatar): simplify overlap mask to use pixel-based SVG math
rbcorrales 301184c
feat(author-profile-social): use pre-defined sizes for icon size
thomasguillot d865c06
feat(author-profile-social): rename panelbody title
thomasguillot fca3579
feat(author-profile-social): add support for block gap, update block …
thomasguillot 8922ba6
feat(author-profile-social): add support for text and background color
thomasguillot a51f325
feat(author-profile-social): rename text and background color labels
thomasguillot e5efd7f
feat(social-button): update mixin to use scale instead of color on :h…
thomasguillot 465c2c9
feat(author-profile-social): add brand style
thomasguillot 202511a
Merge trunk into update/author-profile-social
thomasguillot e6e9bb3
fix: messed up merge
thomasguillot fac1316
Update src/blocks/author-profile-social/edit.jsx
thomasguillot e0eddf9
fix: indentation
thomasguillot 6e4d8ee
Update src/blocks/author-profile-social/edit.jsx
thomasguillot 980b7e3
Update src/blocks/author-profile-social/class-author-profile-social-b…
thomasguillot acee80c
fix: php wrapper style error
thomasguillot 5d10a0f
feat: improve colour controls for author profile social block
thomasguillot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at Core's Social Links block, it uses the
<ul>as the outer wrapper, rather than an extra<div>that the author profile social block uses.I think we can rejig it a bit so the
<ul>is the outermost container, then the block gap stuff should just work without this workaround (cc @rbcorrales in case I am horribly wrong)! This looks like it works, but it'd be nice to take advantage of the baked in way to do it if we can 🙂There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One issue with this approach is that it would leave us with two separate versions of the block that use different structures: the legacy version built with
<div><ul>, and the InnerBlocks version that uses only<ul>.