Skip to content

refactor: format JS#3999

Merged
adekbadek merged 16 commits intotrunkfrom
refactor/format-js-files
Jun 16, 2025
Merged

refactor: format JS#3999
adekbadek merged 16 commits intotrunkfrom
refactor/format-js-files

Conversation

@adekbadek
Copy link
Member

@adekbadek adekbadek commented May 28, 2025

All Submissions:

Changes proposed in this Pull Request:

Formats the code using prettier and ensures formatting is enforced (newspack-scripts@5.6.0).

How to test the changes in this Pull Request:

Run npm run lint:js and observe no errors.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@adekbadek adekbadek force-pushed the refactor/format-js-files branch from 0809044 to 58d10dc Compare June 4, 2025 09:04
@adekbadek adekbadek marked this pull request as ready for review June 4, 2025 09:16
@adekbadek adekbadek requested a review from a team as a code owner June 4, 2025 09:16
@adekbadek adekbadek added the [Status] Needs Review The issue or pull request needs to be reviewed label Jun 4, 2025
Copy link
Member

@miguelpeixe miguelpeixe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

It's nitpicky, but I'd say this qualifies as chore rather than refactor. No code has changed, only linted. Given the number of impacted files, I think refactor may give the wrong impression when reading the commit history.

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Jun 13, 2025
@adekbadek adekbadek merged commit 8a60a8c into trunk Jun 16, 2025
7 checks passed
@adekbadek adekbadek deleted the refactor/format-js-files branch June 16, 2025 09:12
@github-actions
Copy link

Hey @adekbadek, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

@matticbot
Copy link
Contributor

🎉 This PR is included in version 6.9.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 6.10.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 6.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants