Assorted changes

[adekbadek]

All Submissions:

• Have you followed the Newspack Contributing guideline?
• Does your code follow the WordPress' coding standards and VIP Go coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

1. Changes the environment variable name used to enable the experimental auditing features
2. Adds ESP contact "Network Registration Site" meta field on network reader creation or fetch (contribution originally by @dkoo committed to the data-integrity-improvements branch)
3. Adds more data to backfilled users
4. Fixes membership event timestamp for backfilled memberships

(Note: this is a part of integrating the changes from the data-integrity-improvements branch (#89))

How to test the changes in this Pull Request:

1. Set NEWSPACK_NETWORK_EXPERIMENTAL_AUDITING_FEATURES environment variable to true, visit Newspack Network -> Nodes and the admin panel and observe there's a "Synchronizable Users" column present
2. With Mailchimp or ActiveCampaign set as the ESP, register a new reader on a site
3. In the ESP UI, observe the contact has a custom field "Network Registration Site" with the origin site assigned
4. Disable this plugin on the Hub site and create a new user (with a first and last name), and a membership
5. Enable this plugin and run the backfill CLI: wp newspack-network data-backfill all --start=2020-01-01 --end=2024-12-31 --live
6. Visit the Event Log and observe the user_registered event has the first and last name in the event data
7. Observe the membership event has the timestamp same as the membership start date

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

[dkoo]

This is working great! The only issue I see is that when running the backfill script, it's fetching users only who registered on the site you're running the script on (so actual customer or subscriber users, not network_reader users). These users won't have the newspack_remote_site user meta, as this meta is only populated on network_reader users. So we'll need to manually add the network_registration_site meta when syncing to the ESP and assume that the registration site is the current site URL.

[adekbadek]

@dkoo –

it's fetching users only who registered on the site you're running the script on […] These users won't have the newspack_remote_site user meta

That's expected, the "original" users never have the newspack_remote_site user meta assigned, because the site is their origin. The backfill script does not change anything in that regard, unless I'm misreading your comment.

So we'll need to […] assume that the registration site is the current site URL.

Precisely! This is how this plugin worked all the time.

[dkoo]

That's expected, the "original" users never have the newspack_remote_site user meta assigned, because the site is their origin. The backfill script does not change anything in that regard, unless I'm misreading your comment.

Got it, so just to clarify: the backfill script in this PR is only concerned with backfilling registration events for "original" user accounts. So the network_registration_site metadata will be populated on the other backfill process, when we sync contact data for all users (not just original ones, but also network_reader users) to the connected ESP.

[adekbadek]

That's correct. The backfill script in this PR is supposed to be ran on each network site, and then the events will be synchronised.

[matticbot]

🎉 This PR is included in version 1.8.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[matticbot]

🎉 This PR is included in version 1.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀