feat(content-gate): network product and access control by miguelpeixe · Pull Request #303 · Automattic/newspack-network

miguelpeixe · 2026-03-10T17:12:24Z

All Submissions:

Have you followed the Newspack Contributing guideline?
Does your code follow the WordPress' coding standards and VIP Go coding standards?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Add product-level Network IDs to integrate with content gating. This enables cross-site subscription access and purchase restrictions.

Network ID on products: Adds a "Network ID" metabox to WooCommerce product edit screens, allowing admins to link subscription products across sites in a network.
Event sync: Syncs product Network IDs via a new newspack_network_product_updated data event, with incoming event handler, event log item, and CLI backfiller.
Access rules: Hooks into the newspack_access_rules_has_active_subscription filter. When a user has an active subscription on another network site for a product with a matching Network ID, access is granted.
Purchase restrictions: Prevents users from purchasing a subscription product when they already have an active subscription to a product with the same Network ID on another network site.

Closes NPPD-1162.

How to test the changes in this Pull Request:

Set up a network with at least two sites (hub+node)
On both sites, create a WooCommerce subscription product and assign the same Network ID (e.g., premium-access) via the "Newspack Network" metabox on the product edit screen.
On both sites, create a content gate with an access rule requiring that subscription product.
As a reader, purchase the subscription on Site A.
Wait for the subscription data to sync (nodes pull every 2 minutes), or manually trigger a backfill.
On Site B, verify:
- The reader can bypass the content gate (access granted via network subscription).
- The reader cannot purchase the same subscription product — it should show as non-purchasable with a message referencing Site A.
As a logged-out user with the same billing email, attempt to checkout with the subscription on Site B — verify the checkout validation error appears.
On the Hub, check the event log for "Product updated" entries with the correct product name and Network ID.

Other information:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes, as applicable?
Have you successfully ran tests with your changes locally?

Copilot

Pull request overview

Adds product-level “Network ID” support to Newspack Network to enable cross-site Content Gate access checks and to prevent duplicate subscription purchases across network sites.

Changes:

Adds a WooCommerce Product “Network ID” metabox and stores it in product post meta.
Syncs product Network IDs across the network via a new newspack_network_product_updated data event (incoming handler, event log item, and CLI backfiller).
Introduces Content Gate integrations for network-aware access decisions and subscription purchase limiting.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
`includes/woocommerce/class-product-admin.php`	Adds admin UI + persistence for product Network ID metadata.
`includes/woocommerce/class-events.php`	Registers and emits the new product-updated data event.
`includes/incoming-events/class-product-updated.php`	Processes incoming product-updated events and stores synced product data.
`includes/hub/stores/event-log-items/class-product-updated.php`	Adds Hub event log summaries for product updates.
`includes/content-gate/class-access.php`	Grants Content Gate access based on matching Network IDs across sites.
`includes/content-gate/class-limit-purchase.php`	Blocks purchase/checkout when an equivalent network subscription already exists.
`includes/cli/backfillers/class-product-updated.php`	Backfills product-updated events for products with Network IDs.
`includes/class-initializer.php`	Boots the new Product admin and Content Gate integrations.
`includes/class-accepted-actions.php`	Allows `newspack_network_product_updated` events to be accepted/pulled.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

includes/content-gate/class-limit-purchase.php

includes/content-gate/class-access.php

includes/incoming-events/class-product-updated.php

includes/woocommerce/class-product-admin.php

…cess

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

includes/woocommerce/class-product-admin.php

includes/woocommerce/class-events.php

tests/unit-tests/test-content-gate-access.php

includes/hub/stores/event-log-items/class-product-updated.php

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…ic/newspack-network into feat/network-product-id

dkoo

I ran into issues matching up Network IDs when the products in question were variations of a variable subscription. Since the Network ID field attaches to the parent product instead of each individual variation (as I think it should), we should be crawling up the $product->get_parent_id() chain when comparing across sites. And/or, the network_id for a parent product needs to be populated for all of its variations/child products when syncing subscription data across sites.

Non-blocking feedback: I like the introduction of a Network ID string to allow publishers to manually map products across network sites. I wonder if we should also attempt to map by matching product slugs if the ID is empty, to reduce the overhead required for publishers? This probably won't be true of all networks, but many might have products with the same name across all network sites.

miguelpeixe · 2026-03-11T16:39:55Z

I ran into issues matching up Network IDs when the products in question were variations of a variable subscription.

Good catch! Updated in a34d529. Testing it will require another product change event to populate the variant IDs.

Non-blocking feedback: I like the introduction of a Network ID string to allow publishers to manually map products across network sites. I wonder if we should also attempt to map by matching product slugs if the ID is empty, to reduce the overhead required for publishers? This probably won't be true of all networks, but many might have products with the same name across all network sites.

This is the same strategy we have in place for membership plans:

I decided to keep it because:

We don't want to deal with slug collision. It's not uncommon for sites to have a draft product holding the slug and the published product be premium-2, which will unmatch on another site that doesn't have the same issue.
It's not always that the same-slug products are intended to sync in the network. We'd have to create an opt-out strategy or manually tweak the slug to prevent sync.

dkoo

Thanks for the fix for variations, this is testing well now! Some more comments inline about the usage of get_post_meta vs $product->get_meta that I missed in the earlier review.

dkoo · 2026-03-11T16:54:57Z

includes/woocommerce/class-events.php

+		if ( ! $product ) {
+			return;
+		}
+		$network_id = get_post_meta( $product->get_id(), Product_Admin::NETWORK_ID_META_KEY, true );


Should this be $product->get_meta( Product_Admin::NETWORK_ID_META_KEY, true );?

product is still a post type that supports update_post_meta() and get_post_meta(). I'd rather use the WP approach as it should be more stable and standardized. Is there a benefit in using the Woo layer here?

We're using update_post_meta() to set it:

newspack-network/includes/woocommerce/class-product-admin.php

Line 119 in a34d529

update_post_meta( $post_id, self::NETWORK_ID_META_KEY, $network_id );

dkoo · 2026-03-11T16:55:30Z

includes/woocommerce/class-product-admin.php

+	 * @return string The Network ID, or empty string if not set.
+	 */
+	public static function get_network_id( $product_id ) {
+		$network_id = get_post_meta( $product_id, self::NETWORK_ID_META_KEY, true );


Same as above, should we be using $product->get_meta( Product_Admin::NETWORK_ID_META_KEY, true );?

dkoo · 2026-03-11T16:55:35Z

includes/woocommerce/class-product-admin.php

+		if ( function_exists( 'wc_get_product' ) ) {
+			$product = wc_get_product( $product_id );
+			if ( $product && $product->get_parent_id() ) {
+				return get_post_meta( $product->get_parent_id(), self::NETWORK_ID_META_KEY, true );


Same as above, should we be using $product->get_meta( Product_Admin::NETWORK_ID_META_KEY, true );?

dkoo · 2026-03-11T16:55:42Z

includes/woocommerce/class-product-admin.php

+	 * @param \WP_Post $post The post object.
+	 */
+	public static function render_meta_box( $post ) {
+		$network_id = get_post_meta( $post->ID, self::NETWORK_ID_META_KEY, true );


Same as above, should we be using $product->get_meta( Product_Admin::NETWORK_ID_META_KEY, true );?

dkoo

Gotcha, I wasn't sure if products are also stored via HPOS, but it looks like they're not. Should be fine, then.

miguelpeixe added 6 commits March 10, 2026 11:44

feat: add Network ID metabox to WooCommerce products

fd0d561

feat: add product Network ID data event and sync

2991132

feat: add network-aware access rule evaluation via product Network ID

6b6f46f

feat: add product-level network purchase restrictions for content gates

22c80b6

fix: align variable assignment in Access class

a7da93c

fix: cast product ID to string for safe array key lookup

30e6e9f

miguelpeixe requested a review from Copilot March 10, 2026 17:13

Copilot started reviewing on behalf of miguelpeixe March 10, 2026 17:13 View session

Copilot AI reviewed Mar 10, 2026

View reviewed changes

miguelpeixe added 9 commits March 10, 2026 14:42

fix: break after first network subscription validation error

b26a4f9

fix: restrict network purchase checks to subscription products only

c822cb8

fix: disable autoload for network products option

e07c949

fix: allow multiple products to share the same Network ID

b84c44d

test: add unit tests for Content Gate network access

cddca5e

chore: standardize array formatting in unit tests for content gate ac…

f6f9757

…cess

fix: restrict network ID metabox to subscription product types

0ed8466

fix: process product updates for hub-originated events

974e3bf

fix: add WooCommerce active check to product backfiller

11457a6

miguelpeixe requested a review from Copilot March 10, 2026 18:48

Copilot started reviewing on behalf of miguelpeixe March 10, 2026 18:48 View session

Copilot AI reviewed Mar 10, 2026

View reviewed changes

miguelpeixe and others added 4 commits March 10, 2026 16:00

Update includes/hub/stores/event-log-items/class-product-updated.php

0068b15

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix: add WooCommerce active check to product_updated listener

c7e6228

fix: use save_post_product hook and guard against missing WooCommerce

d73b938

Merge branch 'feat/network-product-id' of https://github.com/Automatt…

e1731b4

…ic/newspack-network into feat/network-product-id

miguelpeixe marked this pull request as ready for review March 10, 2026 19:05

miguelpeixe requested a review from a team as a code owner March 10, 2026 19:05

miguelpeixe self-assigned this Mar 10, 2026

miguelpeixe added the [Status] Needs Review label Mar 10, 2026

miguelpeixe requested a review from dkoo March 10, 2026 19:05

dkoo requested changes Mar 10, 2026

View reviewed changes

github-actions bot added the [Status] Needs Changes or Feedback label Mar 10, 2026

miguelpeixe added 3 commits March 11, 2026 13:10

fix: handle network ID for product variations

a34d529

fix: lint and revert unneeded subscription change

561a1b6

fix: remove unnecessary network ID check for variable subscriptions

85f663e

miguelpeixe requested a review from dkoo March 11, 2026 16:40

dkoo requested changes Mar 11, 2026

View reviewed changes

miguelpeixe requested a review from dkoo March 11, 2026 17:17

dkoo approved these changes Mar 11, 2026

View reviewed changes

github-actions bot added [Status] Approved and removed [Status] Needs Review [Status] Needs Changes or Feedback labels Mar 11, 2026

Conversation

miguelpeixe commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

All Submissions:

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Other information:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dkoo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

miguelpeixe commented Mar 11, 2026

Uh oh!

dkoo left a comment

Choose a reason for hiding this comment

Uh oh!

dkoo Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

miguelpeixe Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

dkoo Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

dkoo Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

dkoo Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

dkoo left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

miguelpeixe commented Mar 10, 2026 •

edited

Loading

dkoo left a comment •

edited

Loading