feat(connection): make connection helpers respect bufferTimeoutMS #15229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #15201
Summary
#15201 pointed out an issue where we need to clear a connection's
_lastHeartbeatAtwhen disconnecting, otherwise reconnecting after disconnecting can lead to the connection falsely thinking it is disconnected. This PR makes Mongoose set_lastHeartbeatAt = nullwhen disconnecting and when connecting, to ensure we can rely on_lastHeartbeatAtas an accurate representation of the last time we received aserverHeartbeatSucceededon this connection.As some followup work, I also made it so that
_waitForConnect()respectsbufferTimeoutMS. Right nowbufferTimeoutMSapplies to collection operations (find(), etc.) but not connection operations (listCollections(),createCollection(), etc.), which is very inconsistent because this means connection operations can hang forever.Examples