Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Beta plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Jetpack plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Backup plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Boost plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Search plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Social plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Starter Plugin plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Protect plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Videopress plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Mu Wpcom plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Inspect plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Wpcomsh plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Automattic For agencies client plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Classic Theme helper plugin plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Paypal Payment buttons plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Wpcloud Sso plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
|
@keoshi, current state, not bad! I added some hover too.
Screen.Recording.2026-04-02.at.22.17.02.movI didn't refine the font weight/size/spacing exactly like in your design yet. Couple of issues:When in submenu, and I suppose when translated to longer text, banner becomes two rows: Blue color scheme still doesn't look amazing but others look much better: |
|
Looks great already! Thanks so much for this, @simison. Do you think we should lose the external icon? A button already implies an action. If we do that we could also center the text on the button. |
Code Coverage SummaryCoverage changed in 1 file.
|
|
Here's "Upgrade Jetpack" in different languages (via):
Some screenshot examples:
So I took one-line forcing off (but added
I'd just like to avoid this, which either requires removing the arrow or doing something else, not sure what yet:
|
|
That looks solid, @simison. I think I'd still lean on no character, but I'm ok with it. (A reminder that the external icon is generally used in buttons, not the character) I'm spotting a stay |
Yep, just to mock a situation where the character length of the translated copy just so happens to bump only ↗ to the next line. |
85254eb to
84b0698
Compare
|
@keoshi I removed the arrow:
Let's merge? :-) |
anomiex
left a comment
There was a problem hiding this comment.
@simisonrequested a review from Automattic/jetpack-monorepo as a code owner 2 hours ago
Looks fine from a monorepo perspective. I'll tweak that codeowners setting, GitHub really didn't need to ping us just for composer.lock. 😀
Visually, I personally think this looks better than the previous from the screenshots. 🙂
I do note one oddity though (which may be an issue for a separate PR): If I have only Jetpack Beta Tester installed, the "Upgrade" button still shows up. Since that plugin itself doesn't need a Jetpack plan at all, the upgrade button seems a bit out of place. I don't know if any of our other plugins are in the same situation; I do confirm that Automattic for Agencies Client and Classic Theme Helper Plugin on their own don't add a Jetpack menu in the first place, so no out-of-place button for them.



















Follow-up to #47903
Desktop
Mobile
Proposed changes
Before
Desktop

Mobile

Other information
Related product discussion/links
Does this pull request change what data or activity we track or use?
Testing instructions
jetpack build packages/admin-uiorjetpack watch packages/admin-uiif you wanna tweak CSS.should_show_upgrade_menu()justreturn trueand don't commit ;-)