Skip to content

Sidebar upsell nudge: update visually#47909

Merged
simison merged 9 commits intotrunkfrom
update/sidebar-upsell-visual-update
Apr 6, 2026
Merged

Sidebar upsell nudge: update visually#47909
simison merged 9 commits intotrunkfrom
update/sidebar-upsell-visual-update

Conversation

@simison
Copy link
Copy Markdown
Member

@simison simison commented Apr 2, 2026

Follow-up to #47903

Desktop

image

Mobile

image

Proposed changes

  • Update design for the upsell nudge in the sidebar.

Before

Desktop
image

Mobile
image

Other information

  • Generate changelog entries for this PR (using AI).

Related product discussion/links

Does this pull request change what data or activity we track or use?

Testing instructions

  • jetpack build packages/admin-ui or jetpack watch packages/admin-ui if you wanna tweak CSS.
  • Site without a plan, or in should_show_upgrade_menu() just return true and don't commit ;-)
  • See the sidebar; test the heck out of it in different screen sizes, admin color schemes, etc
  • You can swap color schemes from Users -> Profile

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the update/sidebar-upsell-visual-update branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/sidebar-upsell-visual-update
bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/sidebar-upsell-visual-update

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Beta plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Jetpack plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Backup plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Boost plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Search plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Social plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Starter Plugin plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Protect plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Videopress plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Mu Wpcom plugin:

  • Next scheduled release: WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2)

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Inspect plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Wpcomsh plugin:

  • Next scheduled release: Atomic deploys happen twice daily on weekdays (p9o2xV-2EN-p2)

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Automattic For agencies client plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Classic Theme helper plugin plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Paypal Payment buttons plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Wpcloud Sso plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@simison
Copy link
Copy Markdown
Member Author

simison commented Apr 2, 2026

@keoshi, current state, not bad! I added some hover too.

image
Screen.Recording.2026-04-02.at.22.17.02.mov

I didn't refine the font weight/size/spacing exactly like in your design yet.

Couple of issues:

When in submenu, and I suppose when translated to longer text, banner becomes two rows:
image

Blue color scheme still doesn't look amazing but others look much better:
image

@simison simison added Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Design Review Design has been added. Needs a review! labels Apr 2, 2026
@simison
Copy link
Copy Markdown
Member Author

simison commented Apr 2, 2026

Aight, pushed some changes:

  • No bold font
  • Gave more space above, took some space from the sides
  • Enforced single line, cuts with but can be pretty long before it happens, so very unlikely.
Screenshot 2026-04-02 at 22 27 24

@simison simison requested review from CGastrell and DevinWalker April 2, 2026 19:31
@keoshi
Copy link
Copy Markdown
Contributor

keoshi commented Apr 2, 2026

Looks great already! Thanks so much for this, @simison.

Do you think we should lose the external icon? A button already implies an action.

If we do that we could also center the text on the button.

@jp-launch-control
Copy link
Copy Markdown

jp-launch-control bot commented Apr 2, 2026

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/packages/admin-ui/src/class-admin-menu.php 102/126 (80.95%) -0.15% 0 💚

Full summary · PHP report · JS report

@simison
Copy link
Copy Markdown
Member Author

simison commented Apr 2, 2026

No strong opinion about the ↗ but I centered the text anyway:

image

@simison
Copy link
Copy Markdown
Member Author

simison commented Apr 2, 2026

Here's "Upgrade Jetpack" in different languages (via):

Locale Translation
ar ترقية Jetpack
de Jetpack-Upgrade durchführen
el Αναβάθμιση Jetpack
fr Mettre Jetpack à niveau
he שדרוג Jetpack
id Upgrade Jetpack
it Aggiorna Jetpack
ja Jetpack をアップグレード
ko 젯팩 업그레이드
nb Oppgradering av Jetpack
nl Jetpack upgraden
pl Zaktualizuj Jetpack
pt-br Fazer upgrade do Jetpack
ro Actualizează Jetpack
ru Обновить Jetpack
skr جیٹ پیک اپ گریڈ کرو
sq Përmirësojeni Jetpack-un
sv Uppgradera Jetpack
th อัปเกรด Jetpack
tr Jetpack'i yükselt
vi Nâng cấp Jetpack
zh-cn 升级 Jetpack
zh-tw 升級 Jetpack

Some screenshot examples:

image image image

So I took one-line forcing off (but added text-wrap: pretty):

image image image image image

I'd just like to avoid this, which either requires removing the arrow or doing something else, not sure what yet:

image

@simison
Copy link
Copy Markdown
Member Author

simison commented Apr 2, 2026

Text-wrap "balance" instead of "pretty" works pretty well (and is also supported by Firefox unlike "pretty").

These look better now:

image image image

@keoshi
Copy link
Copy Markdown
Contributor

keoshi commented Apr 3, 2026

That looks solid, @simison. I think I'd still lean on no character, but I'm ok with it. (A reminder that the external icon is generally used in buttons, not the character)

I'm spotting a stay 1 next to Upgrade (Upgrade1), is that intended for testing purposes?

@simison
Copy link
Copy Markdown
Member Author

simison commented Apr 3, 2026

I'm spotting a stay 1 next to Upgrade (Upgrade1), is that intended for testing purposes?

Yep, just to mock a situation where the character length of the translated copy just so happens to bump only ↗ to the next line.

@simison simison force-pushed the update/sidebar-upsell-visual-update branch from 85254eb to 84b0698 Compare April 3, 2026 08:57
@simison
Copy link
Copy Markdown
Member Author

simison commented Apr 3, 2026

@keoshi I removed the arrow:

image

Let's merge? :-)

@github-actions github-actions bot added [Plugin] Automattic For Agencies Client [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Beta For serving live branches and the beta versions. https://github.com/automattic/jetpack-beta [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Classic Theme Helper Plugin [Plugin] Inspect [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] mu wpcom jetpack-mu-wpcom plugin [Plugin] Paypal Payment Buttons [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Starter Plugin [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. [Plugin] Wpcloud Sso [Plugin] Wpcomsh labels Apr 3, 2026
@simison simison marked this pull request as ready for review April 3, 2026 10:46
@simison simison requested a review from a team as a code owner April 3, 2026 10:46
Copy link
Copy Markdown
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simison requested a review from Automattic/jetpack-monorepo as a code owner 2 hours ago

Looks fine from a monorepo perspective. I'll tweak that codeowners setting, GitHub really didn't need to ping us just for composer.lock. 😀

Visually, I personally think this looks better than the previous from the screenshots. 🙂

I do note one oddity though (which may be an issue for a separate PR): If I have only Jetpack Beta Tester installed, the "Upgrade" button still shows up. Since that plugin itself doesn't need a Jetpack plan at all, the upgrade button seems a bit out of place. I don't know if any of our other plugins are in the same situation; I do confirm that Automattic for Agencies Client and Classic Theme Helper Plugin on their own don't add a Jetpack menu in the first place, so no out-of-place button for them.

@simison
Copy link
Copy Markdown
Member Author

simison commented Apr 3, 2026

Mobile version screenshot:

image

Copy link
Copy Markdown
Contributor

@keoshi keoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for including these changes, @simison — appreciate you!

@simison simison merged commit 7f0cd31 into trunk Apr 6, 2026
93 of 95 checks passed
@simison simison deleted the update/sidebar-upsell-visual-update branch April 6, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Package] Admin Ui [Plugin] Automattic For Agencies Client [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Beta For serving live branches and the beta versions. https://github.com/automattic/jetpack-beta [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Classic Theme Helper Plugin [Plugin] Inspect [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] mu wpcom jetpack-mu-wpcom plugin [Plugin] Paypal Payment Buttons [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Starter Plugin [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. [Plugin] Wpcloud Sso [Plugin] Wpcomsh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants