Skip to content

Forms: Remove temporary script deregistering on wp-build dashboard#47631

Merged
dhasilva merged 2 commits intotrunkfrom
update/forms-wp-build-remove-default-scripts-re-add
Mar 17, 2026
Merged

Forms: Remove temporary script deregistering on wp-build dashboard#47631
dhasilva merged 2 commits intotrunkfrom
update/forms-wp-build-remove-default-scripts-re-add

Conversation

@dhasilva
Copy link
Copy Markdown
Contributor

Fixes #

Proposed changes

Removes temporary workaround to wp-build deregistering core's scripts without checking if Gutenberg was activated or not, as it was solved upstream: WordPress/gutenberg#75909

Other information

  • Generate changelog entries for this PR (using AI).

Related product discussion/links

Does this pull request change what data or activity we track or use?

Testing instructions

  • Go to the wp-build dashboard with Gutenberg deactivated
  • Check that the dashboard loads as expected

@dhasilva dhasilva requested a review from a team March 17, 2026 16:12
@dhasilva dhasilva self-assigned this Mar 17, 2026
@dhasilva dhasilva added the [Status] Needs Review This PR is ready for review. label Mar 17, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 17, 2026

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/forms-wp-build-remove-default-scripts-re-add branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/forms-wp-build-remove-default-scripts-re-add

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@jp-launch-control
Copy link
Copy Markdown

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/packages/forms/src/dashboard/class-dashboard.php 67/218 (30.73%) 0.42% -3 💚

Full summary · PHP report · JS report

@dhasilva dhasilva merged commit 2efb476 into trunk Mar 17, 2026
81 of 82 checks passed
@dhasilva dhasilva deleted the update/forms-wp-build-remove-default-scripts-re-add branch March 17, 2026 21:23
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant