renovate: Improve PR creation reliability#47502
Conversation
Set pnpm's `allowUnusedPatches` to avoid erroring out for cases like #47472 (comment). Too bad pnpm 11 is removing `ignorePatchFailures`, that'd be useful for the PR creation too. Also, try creating the change entries even if `pnpm install` fails, as the change entry creation doesn't depend on pnpm. The later `tools/check-intra-monorepo-deps.sh` run will fail, but getting change entries created is still an improvement.
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
tbradsha
left a comment
There was a problem hiding this comment.
Looks like an improvement. Presumably allow-unused-patches would output some messaging even if unused patches exist? If not, and we miss it, I suppose it would result in errors on a local trunk and subsequent trunk-based branches.
|
It'll result in failures in CI jobs on the Renovate PR itself after the PR is created. But the PR will be more complete, allowing it to be fixed with less work. |
Proposed changes
Set pnpm's
allowUnusedPatchesto avoid erroring out for cases like #47472 (comment). Too bad pnpm 11 is removingignorePatchFailures, that'd be useful for the PR creation too.Also, try creating the change entries even if
pnpm installfails, as the change entry creation doesn't depend on pnpm. The latertools/check-intra-monorepo-deps.shrun will fail, but getting change entries created is still an improvement.Other information
Related product discussion/links
None really
Does this pull request change what data or activity we track or use?
No
Testing instructions