Skip to content

renovate: Improve PR creation reliability#47502

Merged
anomiex merged 1 commit intotrunkfrom
update/renovate-allowUnusedPatches
Mar 9, 2026
Merged

renovate: Improve PR creation reliability#47502
anomiex merged 1 commit intotrunkfrom
update/renovate-allowUnusedPatches

Conversation

@anomiex
Copy link
Copy Markdown
Contributor

@anomiex anomiex commented Mar 8, 2026

Proposed changes

Set pnpm's allowUnusedPatches to avoid erroring out for cases like #47472 (comment). Too bad pnpm 11 is removing ignorePatchFailures, that'd be useful for the PR creation too.

Also, try creating the change entries even if pnpm install fails, as the change entry creation doesn't depend on pnpm. The later tools/check-intra-monorepo-deps.sh run will fail, but getting change entries created is still an improvement.

Other information

  • Generate changelog entries for this PR (using AI).

Related product discussion/links

None really

Does this pull request change what data or activity we track or use?

No

Testing instructions

  • 🤷

Set pnpm's `allowUnusedPatches` to avoid erroring out for cases like
#47472 (comment).
Too bad pnpm 11 is removing `ignorePatchFailures`, that'd be useful for
the PR creation too.

Also, try creating the change entries even if `pnpm install` fails, as
the change entry creation doesn't depend on pnpm. The later
`tools/check-intra-monorepo-deps.sh` run will fail, but getting change
entries created is still an improvement.
@anomiex anomiex requested a review from a team March 8, 2026 11:57
@anomiex anomiex self-assigned this Mar 8, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 8, 2026

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the Actions GitHub actions used to automate some of the work around releases and repository management label Mar 8, 2026
Copy link
Copy Markdown
Contributor

@tbradsha tbradsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an improvement. Presumably allow-unused-patches would output some messaging even if unused patches exist? If not, and we miss it, I suppose it would result in errors on a local trunk and subsequent trunk-based branches.

@anomiex
Copy link
Copy Markdown
Contributor Author

anomiex commented Mar 9, 2026

It'll result in failures in CI jobs on the Renovate PR itself after the PR is created. But the PR will be more complete, allowing it to be fixed with less work.

@anomiex anomiex merged commit e211e42 into trunk Mar 9, 2026
72 of 73 checks passed
@anomiex anomiex deleted the update/renovate-allowUnusedPatches branch March 9, 2026 07:52
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Actions GitHub actions used to automate some of the work around releases and repository management [Pri] Normal [Type] Janitorial

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants