Skip to content

Conversation

@enejb
Copy link
Member

@enejb enejb commented Oct 18, 2025

This PR fixed the issue where when a user has selected responses and then switches tabs ( Inbox, Spam, Trash ).
and then navigates back to the previous tab that the selection is still active.

This is unexpected since the selection should be cleared.

Screen.Recording.2025-10-17.at.6.41.38.PM.mov

Proposed changes:

  • This PR clears the selection and move the state of what is selected to the URL.
  • The selection persists across pages.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Go to the dashboard.
Select responses. Notice that the selection is updated in the URL.
Change tabs. ( Inbox, Spam, Trash ). Notice that the selection is cleared in the URL.
Notice that non of the checkboxes are selected.

@enejb enejb requested review from a team and Copilot October 18, 2025 01:41
@enejb enejb added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review This PR is ready for review. [Package] Forms labels Oct 18, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where selected form responses remained active when switching between tabs (Inbox, Spam, Trash) in the Forms dashboard. The solution moves selection state to the URL for persistence across pages and properly clears selections when changing tabs.

Key Changes:

  • Selection state is now derived from URL parameters instead of local component state
  • Selection is cleared from the URL when switching tabs
  • Selection logic updated to merge and deduplicate items across pages

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
projects/plugins/jetpack/changelog/fix-forms-clear-selection-when-switching-tabs Changelog entry documenting the bugfix
projects/packages/forms/src/dashboard/inbox/dataviews/index.js Refactored selection state to read from URL and updated selection merging logic
projects/packages/forms/src/dashboard/components/inbox-status-toggle/index.tsx Added logic to clear selection when switching tabs
projects/packages/forms/changelog/fix-forms-clear-selection-when-switching-tabs Changelog entry for the forms package

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the fix/forms-clear-selection-when-switching-tabs branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack fix/forms-clear-selection-when-switching-tabs

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Feature] Contact Form [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Oct 18, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: November 4, 2025
    • Code freeze: November 3, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@jp-launch-control
Copy link

Code Coverage Summary

Coverage changed in 2 files.

File Coverage Δ% Δ Uncovered
projects/packages/forms/src/dashboard/inbox/dataviews/index.js 0/110 (0.00%) 0.00% 3 ❤️‍🩹
projects/packages/forms/src/dashboard/components/inbox-status-toggle/index.tsx 0/17 (0.00%) 0.00% 2 ❤️‍🩹

Full summary · PHP report · JS report

Copy link
Contributor

@CGastrell CGastrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! :shipit:

@enejb enejb merged commit f713cf5 into trunk Oct 20, 2025
67 checks passed
@enejb enejb deleted the fix/forms-clear-selection-when-switching-tabs branch October 20, 2025 17:11
@github-actions github-actions bot added this to the jetpack/15.2 milestone Oct 20, 2025
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Oct 20, 2025
@enejb enejb mentioned this pull request Oct 20, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Contact Form [Package] Forms [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Type] Bug When a feature is broken and / or not performing as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants