Skip to content

Forms: fix close modal in responsive mode #45541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2025
Merged

Forms: fix close modal in responsive mode #45541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e17219b
Forms: Make it possible to close the modal on mobile responsive view
enejb Oct 17, 2025
379ad37
changelog
enejb Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/packages/forms/changelog/fix-close-modal-forms
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fixed

Forms: fix bug where the responsvie modal is not able to be closed.
11 changes: 10 additions & 1 deletion projects/packages/forms/src/dashboard/components/response-view/single.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,17 @@ const SingleResponseView = ( {
selection,
} ) => {
const [ isChildModalOpen, setIsChildModalOpen ] = useState( false );
const [ isModalOpen, setIsModalOpen ] = useState( true );

const onRequestClose = useCallback( () => {
if ( ! isChildModalOpen ) {
onChangeSelection?.( [] );
}
}, [ onChangeSelection, isChildModalOpen ] );

if ( isMobile ) {
setIsModalOpen( false );
}
}, [ onChangeSelection, isChildModalOpen, setIsModalOpen, isMobile ] );

const handleModalStateChange = useCallback(
isOpen => {
Expand Down Expand Up @@ -104,6 +109,10 @@ const SingleResponseView = ( {
);
}

if ( ! isModalOpen ) {
return null;
}

return (
<Modal
title={ __( 'Response', 'jetpack-forms' ) }
Expand Down
4 changes: 4 additions & 0 deletions projects/plugins/jetpack/changelog/fix-close-modal-forms
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: bugfix

Forms: fix a bug where ther responsive modal is not able to be closed.
Loading