Skip to content

Conversation

@tbradsha
Copy link
Contributor

@tbradsha tbradsha commented Oct 17, 2025

Closes MONOREP-155

As a follow-up to #44574, this gates against direct access to some more files as found in the logs.

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to '..'

@tbradsha tbradsha requested a review from a team October 17, 2025 18:46
@tbradsha tbradsha self-assigned this Oct 17, 2025
@tbradsha tbradsha added [Status] Needs Review This PR is ready for review. [Type] Janitorial labels Oct 17, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the fix/jetpack/direct_access_fatals_part_9 branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack fix/jetpack/direct_access_fatals_part_9
bin/jetpack-downloader test jetpack-mu-wpcom-plugin fix/jetpack/direct_access_fatals_part_9

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: November 4, 2025
    • Code freeze: November 3, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@jp-launch-control
Copy link

jp-launch-control bot commented Oct 17, 2025

Code Coverage Summary

Coverage changed in 24 files. Only the first 5 are listed here.

File Coverage Δ% Δ Uncovered
projects/packages/boost-core/src/lib/class-wpcom-boost-api-client.php 0/15 (0.00%) 0.00% 2 ❤️‍🩹
projects/packages/classic-theme-helper/src/class-main.php 0/32 (0.00%) 0.00% 2 ❤️‍🩹
projects/packages/classic-theme-helper/src/content-options.php 0/55 (0.00%) 0.00% 2 ❤️‍🩹
projects/packages/classic-theme-helper/src/custom-content-types.php 0/94 (0.00%) 0.00% 2 ❤️‍🩹
projects/packages/classic-theme-helper/src/custom-post-types/class-jetpack-testimonial-textarea-control.php 0/10 (0.00%) 0.00% 2 ❤️‍🩹

Full summary · PHP report · JS report

@tbradsha tbradsha merged commit f377106 into trunk Oct 20, 2025
108 of 111 checks passed
@tbradsha tbradsha deleted the fix/jetpack/direct_access_fatals_part_9 branch October 20, 2025 13:11
@github-actions github-actions bot added this to the jetpack/15.2 milestone Oct 20, 2025
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant