-
Notifications
You must be signed in to change notification settings - Fork 817
Forms: Add integration tab content #43530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 1 file.
6 files are newly checked for coverage. Only the first 5 are listed here.
Full summary · PHP report · JS report If appropriate, add one of these labels to override the failing coverage check:
Covered by non-unit tests
|
); | ||
}; | ||
|
||
export default AkismetDashboardCard; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code in this Akismet card is nearly identical to the Akismet card in the jetpack-integrations-modal folder here. The same is true for each of the other cards.
I prepped a draft of this PR that just tried to re-use those same pages, but...
(a) there are some tricky difference - like those use hooks that only work in the block editor,
(b) I wasn't sure how long we'll keep these new cards as we talked about migrating to different components, and
(c) this work is behind a feature flag, and I didn't want to do substantial edits to live code to accommodate feature flagged code (yet).
If we are going to keep these card for a while, it would make sense to consolidate these into the same component, but that can be done as a follow up.
Proposed changes:
A recent PR added an "Integrations" tab to the forms dashboard - behind a feature flag, with placeholder content. This PR adds the actual integrations content and logic. It uses the same components and logic as the integrations modal for the form block.
All of this work is behind a feature flag. To see the Integrations tab, you'll need to add:
add_filter( 'jetpack_forms_enable_integrations_tab', '__return_true' );
Screenshot

Other information:
Jetpack product discussion
Slack:
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
You'll need to enable the feature flag to see the integrations tab:
add_filter( 'jetpack_forms_enable_integrations_tab', '__return_true' );
To test: