Skip to content

Forms: Add integration tab content #43530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 20, 2025
Merged

Conversation

edanzer
Copy link
Contributor

@edanzer edanzer commented May 20, 2025

Proposed changes:

A recent PR added an "Integrations" tab to the forms dashboard - behind a feature flag, with placeholder content. This PR adds the actual integrations content and logic. It uses the same components and logic as the integrations modal for the form block.

All of this work is behind a feature flag. To see the Integrations tab, you'll need to add:

add_filter( 'jetpack_forms_enable_integrations_tab', '__return_true' );

Screenshot
form-integrations-tab

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Slack:

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

You'll need to enable the feature flag to see the integrations tab:
add_filter( 'jetpack_forms_enable_integrations_tab', '__return_true' );

To test:

  • Go to Feedback > Integrations
  • Confirm that screen loads, looks like the screenshot above, and that the various states all work and load as expected: plugins installed/not installed and activated/not activated, Akismet connected with key and not, Google Drive connected and not, etc.

@edanzer edanzer self-assigned this May 20, 2025
@edanzer edanzer added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] In Progress [Pri] Normal [Package] Forms labels May 20, 2025
Copy link
Contributor

github-actions bot commented May 20, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the add/forms-integration-tab-content branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack add/forms-integration-tab-content

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Feature] Contact Form [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels May 20, 2025
Copy link
Contributor

github-actions bot commented May 20, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: June 3, 2025
    • Code freeze: June 2, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link

jp-launch-control bot commented May 20, 2025

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/packages/forms/src/dashboard/integrations/index.tsx 0/15 (0.00%) 0.00% 13 💔

6 files are newly checked for coverage. Only the first 5 are listed here.

File Coverage
projects/packages/forms/src/dashboard/integrations/akismet-card.tsx 0/5 (0.00%) 💔
projects/packages/forms/src/dashboard/integrations/creative-mail-card.tsx 0/4 (0.00%) 💔
projects/packages/forms/src/dashboard/integrations/google-sheets-card.tsx 0/9 (0.00%) 💔
projects/packages/forms/src/dashboard/integrations/jetpack-crm-card.tsx 0/14 (0.00%) 💔
projects/packages/forms/src/dashboard/integrations/salesforce-card.tsx 0/3 (0.00%) 💔

Full summary · PHP report · JS report

If appropriate, add one of these labels to override the failing coverage check: Covered by non-unit tests Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage.

);
};

export default AkismetDashboardCard;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code in this Akismet card is nearly identical to the Akismet card in the jetpack-integrations-modal folder here. The same is true for each of the other cards.

I prepped a draft of this PR that just tried to re-use those same pages, but...
(a) there are some tricky difference - like those use hooks that only work in the block editor,
(b) I wasn't sure how long we'll keep these new cards as we talked about migrating to different components, and
(c) this work is behind a feature flag, and I didn't want to do substantial edits to live code to accommodate feature flagged code (yet).

If we are going to keep these card for a while, it would make sense to consolidate these into the same component, but that can be done as a follow up.

@edanzer edanzer merged commit 0c3ab14 into trunk May 20, 2025
66 of 67 checks passed
@edanzer edanzer deleted the add/forms-integration-tab-content branch May 20, 2025 20:08
@github-actions github-actions bot added this to the jetpack/14.7 milestone May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Contact Form [Package] Forms [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant