Skip to content

Forms: Add Create Form button to dashboard header #43529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 20, 2025

Conversation

dhasilva
Copy link
Contributor

Fixes FORMS-29

Proposed changes:

  • Adds the button to the header, fixing the button colors to green
  • Converts the dashboard index and layout components to typescript

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to the dashboard (Feedback menu)
  • Check that the "Create form" button is green and is present in the dashboard header, as shown in the figma file
  • Check that the active state of the Export button is fixed (the text was black, now it is green)
  • Check that the focus color for both buttons is green (was black on Jetpack sites and pink on simple sites)
  • Check that the button works as expected
  • Check that it does not break the layout on mobile viewport

image
2025-05-19_20-31
Screenshot from 2025-05-19 20-29-52
Screenshot from 2025-05-19 20-30-01

@dhasilva dhasilva requested a review from a team May 19, 2025 23:46
@dhasilva dhasilva self-assigned this May 19, 2025
@dhasilva dhasilva added [Type] Task [Status] Needs Team Review Obsolete. Use Needs Review instead. I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. labels May 19, 2025
Copy link
Contributor

github-actions bot commented May 19, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the update/forms-dashboard-create-form-button branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/forms-dashboard-create-form-button
bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/forms-dashboard-create-form-button

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Copy link

Code Coverage Summary

2 files are newly checked for coverage.

File Coverage
projects/packages/forms/src/dashboard/components/layout/index.tsx 0/21 (0.00%) 💔
projects/packages/forms/src/dashboard/index.tsx 0/9 (0.00%) 💔

Full summary · PHP report · JS report

Coverage check overridden by I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. .

@dhasilva dhasilva merged commit d9ff493 into trunk May 20, 2025
88 of 89 checks passed
@dhasilva dhasilva deleted the update/forms-dashboard-create-form-button branch May 20, 2025 20:20
@github-actions github-actions bot removed the [Status] Needs Team Review Obsolete. Use Needs Review instead. label May 20, 2025
@simison
Copy link
Member

simison commented May 21, 2025

@dhasilva @ilonagl mobile version feels a bit tight, and I'm worried in some languages there won't be space for longer copy — how could we improve it?

Screenshot 2025-05-21 at 10 38 01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants