-
Notifications
You must be signed in to change notification settings - Fork 818
Forms: add submenu item on dotcom #43527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Mu Wpcom plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Wpcomsh plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 1 file.
Coverage check overridden by
Coverage tests to be added later
|
c9aea1f
to
d0afd20
Compare
3804358
to
e666925
Compare
d9c1032
to
c5dd7b8
Compare
moar fixing on the lock file make sure method exists
f0619a0
to
c3f3c26
Compare
__( 'Jetpack Forms', 'jetpack-mu-wpcom' ), | ||
__( 'Forms', 'jetpack-mu-wpcom' ), | ||
'edit_pages', | ||
$handler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$handler
I believe is the wrong thing here. This needs to be jetpack-forms-admin
, not the full URL. Just the slug IIRC.
WIP
Depends on #43295
Fixes #
Proposed changes:
TBD
Other information:
Jetpack product discussion
none yet
Does this pull request change what data or activity we track or use?
No
Testing instructions:
TBD