Skip to content

Forms: add submenu item on dotcom #43527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: trunk
Choose a base branch
from

Conversation

CGastrell
Copy link
Contributor

@CGastrell CGastrell commented May 19, 2025

WIP

Depends on #43295

Fixes #

Proposed changes:

TBD

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

none yet

Does this pull request change what data or activity we track or use?

No

Testing instructions:

TBD

@CGastrell CGastrell self-assigned this May 19, 2025
@CGastrell CGastrell added [Status] In Progress [Type] Task [Plugin] mu wpcom jetpack-mu-wpcom plugin Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR labels May 19, 2025
Copy link
Contributor

github-actions bot commented May 19, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (WordPress.com Site Helper), and enable the add/jetpack-forms-dotcom-submenu branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/jetpack-forms-dotcom-submenu

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented May 19, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Mu Wpcom plugin:

  • Next scheduled release: WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2)

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Wpcomsh plugin:

  • Next scheduled release: Atomic deploys happen twice daily on weekdays (p9o2xV-2EN-p2)

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link

jp-launch-control bot commented May 19, 2025

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/packages/jetpack-mu-wpcom/src/features/wpcom-admin-menu/wpcom-admin-menu.php 0/311 (0.00%) 0.00% 12 💔

Full summary · PHP report

Coverage check overridden by Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR .

@CGastrell CGastrell force-pushed the add/jetpack-forms-dotcom-submenu branch from c9aea1f to d0afd20 Compare May 19, 2025 22:52
@CGastrell CGastrell force-pushed the add/jetpack-forms-dotcom-submenu branch 3 times, most recently from 3804358 to e666925 Compare May 20, 2025 04:43
@CGastrell CGastrell changed the base branch from trunk to add/jetpack-forms-dev-menu-entry-poc May 20, 2025 04:44
@CGastrell CGastrell changed the base branch from add/jetpack-forms-dev-menu-entry-poc to trunk May 20, 2025 13:53
@CGastrell CGastrell force-pushed the add/jetpack-forms-dotcom-submenu branch from d9c1032 to c5dd7b8 Compare May 20, 2025 13:54
@CGastrell CGastrell force-pushed the add/jetpack-forms-dotcom-submenu branch from f0619a0 to c3f3c26 Compare May 20, 2025 21:07
__( 'Jetpack Forms', 'jetpack-mu-wpcom' ),
__( 'Forms', 'jetpack-mu-wpcom' ),
'edit_pages',
$handler
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$handler I believe is the wrong thing here. This needs to be jetpack-forms-admin, not the full URL. Just the slug IIRC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR [mu wpcom Feature] Wpcom Admin Menu [Package] Jetpack mu wpcom WordPress.com Features [Plugin] mu wpcom jetpack-mu-wpcom plugin [Plugin] Wpcomsh [Status] In Progress [Type] Task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants