-
Notifications
You must be signed in to change notification settings - Fork 818
Boost: Align Cloud response with plugin for BG Images #43490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: update/boost/link-cloud-sizes
Are you sure you want to change the base?
Boost: Align Cloud response with plugin for BG Images #43490
Conversation
…enhance background image handling, and add new methods for srcsets and sizes retrieval.
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Boost plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryNo summary data is available for parent commit dcb8a8b, so cannot calculate coverage changes. 😴 If that commit is a feature branch rather than a trunk commit, this is expected. Otherwise, this should be updated once coverage for dcb8a8b is available. Full summary · PHP report · JS report Coverage check overridden by
Coverage tests to be added later
|
projects/plugins/boost/app/modules/optimizations/lcp/class-lcp-optimizer.php
Outdated
Show resolved
Hide resolved
projects/plugins/boost/app/modules/optimizations/lcp/class-lcp-optimizer.php
Outdated
Show resolved
Hide resolved
…styling method to ensure non-empty and numeric values
…r 1x, 2x, and 3x device pixel ratios, ensuring better image responsiveness across various screen sizes.
Note
Merge this PR after #43420 is merged.
Resolves HOG-108: Boost Plugin: Align Cloud response with plugin for BG Images
Proposed changes:
Other information:
Jetpack product discussion
Boost: Improve visitor experience by delivering key images faster - better LCP
Does this pull request change what data or activity we track or use?
N/A
Testing instructions:
Prerequisites
JETPACK_BOOST_ALPHA_FEATURES
)Apply the following snippet below to test for multiple responsive changes of the LCP Background Image.
Width Changes