-
Notifications
You must be signed in to change notification settings - Fork 817
WoA: Clarify function names and comments related to checking for WoA sites #43481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WoA: Clarify function names and comments related to checking for WoA sites #43481
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 1 file.
|
… now that docblocks have been added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look sensible and tests as expected.
Thanks for the work here @coder-karen!
Fixes VULCAN-93
Proposed changes:
isJetpackSelfHostedSite
). The intention is to make it clearer thatisWoASite
should be the go-to option for WoA sites, and functions mentioning Atomic refer to the Atomic platform (including Jurassic Ninja, Pressable, and others).isWoASite
function within theshared-extension-utils
package, which is a duplicate ofisAtomicSite
(to be removed later, as well as replacingisAtomicSite
usage in theshared-extension-utils
package).isAtomicSite
usage toisWoASite
where the functionality was imported fromstate/initial-state
, as both functions do the same (the former was intended to be deprecated when the latter was introduced four years ago in Admin Page: Do not display version numbers on Atomic platform #21533).reducer.js
file due to linter requests.Other information:
Jetpack product discussion
n/a
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
isWoASite
function is a duplication ofisAtomicSite
in theshared-extension-utils
packageTo test the function replacements:
/wp-admin/admin.php?page=jetpack#/dashboard
- find the 'Akismet Anti-Spam' card. Open up the info popup, and on a Jurassic Ninja site you should see a 'Learn more' link leading tohttps://akismet.com/features
. On a WoA site, there should be no 'Learn more' link.