fix invalid sql in assign-user-to-coauthor subcommand #1074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ensure that the list of post-types is correctly wrapped in single quotes to ensure that the resulting sql is valid. currently $post_types evaluates to `post','page` resulting in an invalid sql query, after the change $post_type will evaluate to `'post','page'` with is the expected syntax for this sql query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ensure that the list of post-types is correctly wrapped in single quotes to ensure that the resulting sql is valid.
currently $post_types evaluates to
post','pageresulting in an invalid sql query, after the change $post_type will evaluate to'post','page'with is the expected syntax for this sql queryDeploy Notes
N/A
Steps to Test
Run
wp co-authors-plus assign-user-to-coauthor --user_login=<user_login> --coauthor=<cap-user_login>confirm that the command executes as expected without the errorWordPress database error You have an error in your SQL syntax;being returned