Feature: Add objective result Unlock Perma KT Skip#50
Open
kielbasiago wants to merge 2 commits intoAtmaTek:mainfrom
Open
Feature: Add objective result Unlock Perma KT Skip#50kielbasiago wants to merge 2 commits intoAtmaTek:mainfrom
kielbasiago wants to merge 2 commits intoAtmaTek:mainfrom
Conversation
kielbasiago
commented
May 27, 2022
data/event_bit.py
Outdated
| ALWAYS_CLEAR = 0x176 # this event_bit is always clear, used for branching | ||
|
|
||
| # bits 0x1e6-0x1ed Unused, as the SNES versions feature 20 rare item slots rather than 30 | ||
| UNLOCKED_PERMA_KT_SKIP = 0x1e6 # custom |
Author
There was a problem hiding this comment.
Anyone have an idea where in the WC code would be most proper to clear this event bit when starting the game?
Unsure if it is a real concern or not for this to already somehow be set on game start.
I tried to add field.SetEventBit(event_bit.UNLOCKED_PERMA_KT_SKIP) to start.py but with -oa 2.0.0 -ob 61.0.0 it would show two "Unlocked Perma KT Skip" dialogs instead of two separate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
Unlock Perma KT Skipresult, which will function similarly to the skip prior to 1.0 release where it will not be reset upon warping outRenamed the previous skip result to "Unlock One KT Skip" so it is more clear that it is not repeatable
Testing
Unlock One KT Skip
Preview: https://youtu.be/yOqwj_9Gxbk
wc.py -i /ff3.smc -oa 2.0.0 -ob 3.0.0 -sc1 random -sc2 random -sc3 random -sws 5Unlock Perma KT Skip
Preview: https://youtu.be/GeqFQ9tIl98
wc.py -i /ff3.smc -oa 2.0.0 -ob 61.0.0 -sc1 random -sc2 random -sc3 random -sws 5Neither Skip
No preview for this one, but tested locally and it works
wc.py -i /ff3.smc -oa 2.0.0 -sc1 random -sc2 random -sc3 random -sws 5