fix(controller/autocomplete): preventing additional render events fro…#232
Open
fix(controller/autocomplete): preventing additional render events fro…#232
Conversation
Contributor
korgon
commented
Mar 10, 2026
- preventing sending render events on repeated searches in autocomplete
- extending click debounce to 1000ms
…m being sent to beacon on repeated searches
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces duplicate tracking events by suppressing autocomplete render events on repeated/cached searches and increasing the click de-duplication debounce window to 1000ms.
Changes:
- Skip sending
autocomplete.renderbeacon events when the search is detected as repeated (sameresponseId). - Increase click de-duplication timeout from 300ms to 1000ms.
- Add a Cypress E2E test intended to ensure repeated searches don’t emit extra autocomplete render/impression events.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/snap-preact-demo/tests/cypress/e2e/tracking/track.cy.js | Adds a new Cypress test for repeated-search tracking behavior (currently has a logic issue). |
| packages/snap-controller/src/utils/isClickWithinProductLink.ts | Updates the shared click de-duplication timeout constant to 1000ms. |
| packages/snap-controller/src/Autocomplete/AutocompleteController.ts | Detects repeated searches by responseId and suppresses render tracking for repeats. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/snap-preact-demo/tests/cypress/e2e/tracking/track.cy.js
Outdated
Show resolved
Hide resolved
packages/snap-preact-demo/tests/cypress/e2e/tracking/track.cy.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.