Skip to content

fix(icon): fixing broken icons after stroke default color change#229

Open
chrisFrazier77 wants to merge 1 commit intodevelopfrom
icon-fixes
Open

fix(icon): fixing broken icons after stroke default color change#229
chrisFrazier77 wants to merge 1 commit intodevelopfrom
icon-fixes

Conversation

@chrisFrazier77
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings March 6, 2026 16:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to restore correct rendering for icons affected by a default stroke color change by ensuring currentColor-based strokes have an appropriate color context and by redefining specific icons using multi-element SVG definitions.

Changes:

  • Update filters, bullet, and bullet-o icon definitions from single SVG path strings to arrays of SVG elements with explicit attributes (including stroke: currentColor).
  • Set the root SVG color style in Icon so stroke="currentColor" elements render with the expected color.
  • Update the Icon Storybook CustomPath example to demonstrate array-based SVG element paths.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
packages/snap-preact/components/src/components/Atoms/Icon/paths.tsx Reworks select icons into multi-element SVG definitions using currentColor stroke.
packages/snap-preact/components/src/components/Atoms/Icon/Icon.tsx Adds root color styling so currentColor strokes resolve predictably.
packages/snap-preact/components/src/components/Atoms/Icon/Icon.stories.tsx Updates the CustomPath story to use an array-based SVG path example and updated viewBox.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chrisFrazier77 chrisFrazier77 requested a review from korgon March 6, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants