fix(icon): fixing broken icons after stroke default color change#229
Open
chrisFrazier77 wants to merge 1 commit intodevelopfrom
Open
fix(icon): fixing broken icons after stroke default color change#229chrisFrazier77 wants to merge 1 commit intodevelopfrom
chrisFrazier77 wants to merge 1 commit intodevelopfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to restore correct rendering for icons affected by a default stroke color change by ensuring currentColor-based strokes have an appropriate color context and by redefining specific icons using multi-element SVG definitions.
Changes:
- Update
filters,bullet, andbullet-oicon definitions from single SVG path strings to arrays of SVG elements with explicit attributes (includingstroke: currentColor). - Set the root SVG
colorstyle inIconsostroke="currentColor"elements render with the expected color. - Update the Icon Storybook
CustomPathexample to demonstrate array-based SVG element paths.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/snap-preact/components/src/components/Atoms/Icon/paths.tsx | Reworks select icons into multi-element SVG definitions using currentColor stroke. |
| packages/snap-preact/components/src/components/Atoms/Icon/Icon.tsx | Adds root color styling so currentColor strokes resolve predictably. |
| packages/snap-preact/components/src/components/Atoms/Icon/Icon.stories.tsx | Updates the CustomPath story to use an array-based SVG path example and updated viewBox. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/snap-preact/components/src/components/Atoms/Icon/Icon.stories.tsx
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.