Merged
Conversation
Contributor
korgon
commented
Mar 5, 2026
korgon
commented
- removing metrics generation and upload for now
chrisFrazier77
approved these changes
Mar 5, 2026
dkonieczek
approved these changes
Mar 5, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Removes (disables) metrics generation and S3 upload from the publish GitHub Actions workflow.
Changes:
- Commented out the “Generate Metrics Files” step.
- Commented out the “Upload Metrics Files to S3” step.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+65
to
+69
| # - name: Generate Metrics Files | ||
| # run: npm run build:metrics | ||
|
|
||
| - name: Upload Metrics Files to S3 | ||
| run: aws s3 sync --region us-east-1 ./metrics/data s3://datawarehouse-stage/team-metrics-import/ No newline at end of file | ||
| # - name: Upload Metrics Files to S3 | ||
| # run: aws s3 sync --region us-east-1 ./metrics/data s3://datawarehouse-stage/team-metrics-import/ No newline at end of file |
There was a problem hiding this comment.
With the metrics steps commented out, the workflow still configures AWS credentials, which is now unused. This keeps an unnecessary dependency on AWS secrets and can cause the job to fail if those secrets are unavailable; consider removing the AWS credential step (or guarding it with the same condition as metrics when re-enabled).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.