Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIS-305: Improved Performance When Fetching List Entries for Browse Categories #2225

Conversation

LeoStoyanovByWater
Copy link
Contributor

  • Modified UserList::getListEntries() to do SQL-level pagination rather than PHP array slicing of all list entries.
  • Removed dynamic weighting from UserList::getListEntries().
  • Moved weighting to be performed when titles are added or removed from a patron's list.

To test:

  1. Create a very large list of titles (e.g., 600-1,000+) for a patron as which you are masquerading.
  2. Create a browse category out of that list.
  3. Navigate to the browse category page, and it will likely output an AJAX request error. Depending on the load the server can bear, there may be no error; but, with 1,000+ titles being loaded from the list, an error is guaranteed.
  4. Apply the patch and reload the browse category page. The page should load faster with no AJAX request error.

@mdnoble73 mdnoble73 merged commit 74f9fdd into Aspen-Discovery:25.02.00 Feb 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants