Skip to content

Added Merge Sort , Bubble sort and Heap Operations with Python #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

prkhrv
Copy link

@prkhrv prkhrv commented Oct 4, 2018

Description

  • Added the algorithm for merge sort and bubble sort.

Related Issue

fixes #204
fixes #201

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • New Algorithm (non-breaking change which adds functionality)

Checklist:

  • My code follows the code style of this project.

  • I have read the CONTRIBUTING document.

@GnikDroy
Copy link
Contributor

GnikDroy commented Oct 4, 2018

It is fine since it is your first time. But please comment on the issue before you put up a pull request. Multiple people seemed to be working on this issue. Take that into consideration from next time. Anyway welcome to the project.

Copy link
Contributor

@GnikDroy GnikDroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please name your variables properly. One letter variables are very unconventional. As has already been said, could you please revise PEP8.

@prkhrv
Copy link
Author

prkhrv commented Oct 4, 2018

@GnikDroy Sorry I didn't know. I will Comment before making a PR next time. and I have renamed the variables as you recommended.

@GnikDroy
Copy link
Contributor

GnikDroy commented Oct 4, 2018

@prkhrv No problem. Happens to the best of us. This is your first time contributing anyway.

Could you keep the bubble sort algorithm in a function? Write some code that sorts a test array and prints out to screen. This will help us check your algorithm. Also, could you rename your variables in mergesort as well. Also, take @punkyoon advice and read the PEP8. It will help you.

@GnikDroy GnikDroy added good first issue Good for newcomers python labels Oct 4, 2018
@prkhrv prkhrv changed the title Added Merge Sort and Bubble sort with Python Added Merge Sort , Bubble sort and Heap Sort with Python Oct 4, 2018
@GnikDroy
Copy link
Contributor

GnikDroy commented Oct 4, 2018

@prkhrv Can you remove heap sort and implement a heap instead? You said in #206 you would contribute in heap. Heap Sort is #202 which was assigned to @punkyoon and is addressed by pull request #213

@prkhrv
Copy link
Author

prkhrv commented Oct 4, 2018

Oh! Yeah, Now i saw that , I will sure :)

@prkhrv prkhrv changed the title Added Merge Sort , Bubble sort and Heap Sort with Python Added Merge Sort , Bubble sort and Heap Operations with Python Oct 4, 2018
vinaypathak07 pushed a commit to vinaypathak07/codezilla that referenced this pull request Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Merge Sort (Python) Implement Bubble Sort (Python)
3 participants