-
Notifications
You must be signed in to change notification settings - Fork 181
Added Merge Sort , Bubble sort and Heap Operations with Python #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
It is fine since it is your first time. But please comment on the issue before you put up a pull request. Multiple people seemed to be working on this issue. Take that into consideration from next time. Anyway welcome to the project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please name your variables properly. One letter variables are very unconventional. As has already been said, could you please revise PEP8.
@GnikDroy Sorry I didn't know. I will Comment before making a PR next time. and I have renamed the variables as you recommended. |
@prkhrv No problem. Happens to the best of us. This is your first time contributing anyway. Could you keep the bubble sort algorithm in a function? Write some code that sorts a test array and prints out to screen. This will help us check your algorithm. Also, could you rename your variables in mergesort as well. Also, take @punkyoon advice and read the PEP8. It will help you. |
Oh! Yeah, Now i saw that , I will sure :) |
Description
Related Issue
fixes #204
fixes #201
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist:
My code follows the code style of this project.
I have read the CONTRIBUTING document.