Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update precedence rules such that "post release" versioning is possible for metadata #173

Merged
merged 3 commits into from
Feb 1, 2025

Conversation

AshleighAdams
Copy link
Owner

@AshleighAdams AshleighAdams commented Feb 1, 2025

This means the following order takes precedence:

  • 1.0.0-alpha

  • 1.0.0-alpha+post

  • 1.0.0

  • 1.0.0+post

  • Tests added

  • Linked issue if exists

  • Updated documentation

…le for metadata

This means the following order takes precedence:

1.0.0-alpha
1.0.0-alpha+post
1.0.0
1.0.0+post
@AshleighAdams AshleighAdams changed the title Change meta ordering Update precedence rules such that "post release" versioning is possible for metadata Feb 1, 2025
@AshleighAdams AshleighAdams added the enhancement New feature or request label Feb 1, 2025
@AshleighAdams AshleighAdams self-assigned this Feb 1, 2025
@AshleighAdams
Copy link
Owner Author

Note that this is "sort of" a breaking change, but it's a change in behavior where the prior behavior for Verlite usage ran into an "undefined" behavior, i.e. what tag to select as the "highest" given multiple meta tags on a single commit. It now mirrors the behavior of prereleases, but their comparison with meta vs without meta is inverted such that 1.0.0+abc comes after 1.0.0, but 1.0.0+abc.1 comes before 1.0.0+abc.2

@AshleighAdams AshleighAdams force-pushed the change-meta-ordering branch 2 times, most recently from 3484fd6 to 8dca79b Compare February 1, 2025 20:31
@AshleighAdams AshleighAdams merged commit 44a6412 into master Feb 1, 2025
8 of 10 checks passed
@AshleighAdams AshleighAdams deleted the change-meta-ordering branch February 1, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant