Skip to content

Improved binary decoding performance and other minor fixes. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
RedMser wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Improved binary decoding performance and other minor fixes. #1

RedMser wants to merge 4 commits into from

Conversation

@RedMser
Copy link

@RedMser RedMser commented Sep 23, 2018 •
edited
Loading

Performance boost from reflection changes:

  • Perf_Load_Binary5 runs around 40 milliseconds faster
  • Loading bigger binary DMX data (around 50MB) ran 3 seconds faster (from 19 seconds to 16 seconds)

EDIT: Similar changes might be possible here, since the TypeToId function calls IsDatamodelArrayType as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@RedMser