[fix] Adding check to verify log file was passed into klipper service #595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a safeguard to prevent errors when the Klipper service does not receive a log file parameter. The fix checks if a log file path is provided before attempting to create the AFC.log file, and falls back to using the root logger when no log file is specified.
Key changes:
- Modified logger initialization to check for the presence of
log_filein printer start arguments - Added conditional logic to handle cases where logging to file is not possible
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| extras/AFC_logger.py | Added conditional check for log_file parameter and fallback to root logger when not provided |
| CHANGELOG.md | Documented the fix for the log file error |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jimmyjon711
force-pushed
the
issue_593
branch
from
01a53b3 to
08856d3
Compare
- Does not log to file if log file was not passed into service Fixes ArmoredTurtle#593
jimmyjon711
force-pushed
the
issue_593
branch
from
08856d3 to
c750344
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major Changes in this PR
Adds check to verify that log file was passed into klipper service before trying to create AFC.log file
Fixes #593
How the changes in this PR are tested
Removed passing in log file to klipper service to replicate and verify fix
Logging to stdout instead
With fix implemented, no logging to stdout when log file is supplied
PR Checklist: (Checked-off items are either done or do not apply to this PR)
NOTE: GitHub Copilot may be used for automated code reviews, however as it is an automated system, it's suggestions
may not be correct. Please do not rely on it to catch all issues. Please review any suggestions it makes and use your
own judgement to determine if they are correct.