-
Notifications
You must be signed in to change notification settings - Fork 69
[Enhancement] Updating print assist to be more linear with spool weight #587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enhances the print assist feature to scale more linearly with spool weight, enabling it to remain active throughout printing rather than only on light spools. The changes replace the previous time-based cruise calculation with a new weight-based algorithm that accounts for motor RPM, gear ratios, and spool dimensions.
Key Changes
- Replaced deprecated parameters (
cycles_per_rotation,pwm_value,mm_movement) with new physical parameters (spool_ratio,full_weight,espool_rot_dist,max_motor_rpm,spool_inner_diameter) - Refactored
calculate_cruise_time()to compute assist timing based on current spool weight rather than fixed movement amounts - Updated default values for
spool_inner_diameter(100mm → 75mm) andassist_max_motor_rpm(500 → 465)
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| extras/AFC_unit.py | Adds new physical parameters for gear ratio, spool weight, and rotation distance; removes deprecated timing parameters |
| extras/AFC_spool.py | Integrates full_weight parameter from spool metadata to support weight-based calculations |
| extras/AFC_lane.py | Updates default values for inner diameter and max motor RPM to reflect new calculation requirements |
| extras/AFC_assist.py | Core refactoring of cruise time calculation logic, property additions for new parameters, and command documentation updates |
| extras/AFC.py | Adds global configuration for spool_ratio and full_weight; includes string formatting fix |
| CHANGELOG.md | Documents the enhancement with appropriate changelog entry |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2d217d3 to
0c40b39
Compare
- Added helper function for calculating circumference for inner/outer diameters - Added typing
0c40b39 to
91944dc
Compare
Major Changes in this PR
Breaking changes if user have the following variables defined then they will need to remove them:
Graph of cruise time compared to spool weight

Notes to Code Reviewers
How the changes in this PR are tested
PR Checklist: (Checked-off items are either done or do not apply to this PR)
NOTE: GitHub Copilot may be used for automated code reviews, however as it is an automated system, it's suggestions
may not be correct. Please do not rely on it to catch all issues. Please review any suggestions it makes and use your
own judgement to determine if they are correct.