Hide projectiles from spectators and add getSpectators #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added logic to hide projectiles from spectators when a player shoots a bow. Introduced SpectateManager#getSpectators() to retrieve the current spectator players. Also added @NotNull and @Unmodifiable annotations for improved type safety.
The @Unmodifiable annotation was removed from the getSpectators method, possibly to allow modification of the returned list or to correct an inaccurate annotation.
There was a problem hiding this comment.
Pull Request Overview
This PR enhances spectator functionality by preventing spectators from seeing projectiles when players shoot bows and adds a method to retrieve all spectator players. The changes improve spectator isolation and provide better access to spectator information.
Key Changes:
- Added
SpectateManager#getSpectators()method to retrieve active spectator players - Implemented projectile hiding from spectators via
EntityShootBowEventhandler - Enhanced type safety with
@NotNulland@Unmodifiableannotations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| SpectateManager.java | Added getSpectators() method to retrieve active spectator players and added @NotNull annotations for type safety |
| SpectateListener.java | Added event handler to hide projectiles from spectators when players shoot bows, added @NotNull annotations throughout, and added redundant Listener interface implementation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/main/java/me/roinujnosde/titansbattle/listeners/SpectateListener.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added logic to hide projectiles from spectators when a player shoots a bow. Introduced SpectateManager#getSpectators() to retrieve the current spectator players. Also added @NotNull and @Unmodifiable annotations for improved type safety.