Skip to content
This repository has been archived by the owner on Oct 1, 2021. It is now read-only.

refactor: use conditional classes for input components #653

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Highjhacker
Copy link
Contributor

Summary

https://app.clickup.com/t/rag8g9

Concern all blade files located within inputs

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I provided a screenshot of my changes to the component (if applicable)
  • I regenerated the icons.html file and checked if my newly added icon is shown correctly (if necessary)
  • I added an explanation on how to use the component to the readme (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ItsANameToo ItsANameToo changed the title refactor: use conditional classes for inputs components refactor: use conditional classes for input components Sep 16, 2021
Copy link
Contributor

@alexbarnsley alexbarnsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all of the $errors->has('name') lines are incorrect. I think they should be $errors->has($name). Please test this first though, I only tested it when looking at #652

resources/views/inputs/input-with-prefix.blade.php Outdated Show resolved Hide resolved
@alexbarnsley alexbarnsley marked this pull request as draft September 16, 2021 21:22
@alexbarnsley alexbarnsley self-assigned this Sep 16, 2021
@Highjhacker Highjhacker marked this pull request as ready for review September 17, 2021 09:17
@ItsANameToo ItsANameToo marked this pull request as draft September 20, 2021 10:11
@ItsANameToo
Copy link
Collaborator

make sure to test the components @Highjhacker

@ItsANameToo
Copy link
Collaborator

status on this @Highjhacker ?

@Highjhacker
Copy link
Contributor Author

@ItsANameToo I was certain to have marked it as ready for review, my bad.

@Highjhacker Highjhacker marked this pull request as ready for review September 24, 2021 13:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants