This repository has been archived by the owner on Oct 1, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
refactor: use conditional classes for input components #653
Open
Highjhacker
wants to merge
7
commits into
master
Choose a base branch
from
refactor/class-directive-part-4
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Highjhacker
requested review from
alexbarnsley and
ItsANameToo
as code owners
September 16, 2021 09:38
ItsANameToo
changed the title
refactor: use conditional classes for inputs components
refactor: use conditional classes for input components
Sep 16, 2021
alexbarnsley
suggested changes
Sep 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all of the $errors->has('name')
lines are incorrect. I think they should be $errors->has($name)
. Please test this first though, I only tested it when looking at #652
ItsANameToo
suggested changes
Sep 20, 2021
make sure to test the components @Highjhacker |
status on this @Highjhacker ? |
@ItsANameToo I was certain to have marked it as ready for review, my bad. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://app.clickup.com/t/rag8g9
Concern all blade files located within inputs
Checklist
icons.html
file and checked if my newly added icon is shown correctly (if necessary)