fix(p2p): download messages from higher round #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastijankuzner
deleted the
fix/p2p/download-messages-if-round-is-higher
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Download prevotes and precommits form highest round possible. If node have highest round with +1/3 prevotes, then this round is returned to allow downloading node to increase the round. If round with <1/3 prevotes is found than return previous round or requested round data.
Node will try to download messages from the highest round possible. This is separate mode. First mode is to download messages from the node with the same round.
Remove canDownload* checks from header and move it under downloaders. Fix proposal downloader allow multiple rounds.
Checklist