Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hard-coded errors #78

Merged
merged 8 commits into from
Aug 17, 2023
Merged

Fix hard-coded errors #78

merged 8 commits into from
Aug 17, 2023

Conversation

Aritra8438
Copy link
Owner

No description provided.

Signed-off-by: Aritra Majumder <[email protected]>
Signed-off-by: Aritra Majumder <[email protected]>
Signed-off-by: Aritra Majumder <[email protected]>
@vercel
Copy link

vercel bot commented Aug 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eco-metrics-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 17, 2023 7:23am

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (dce670c) 97.98% compared to head (54fe03b) 97.99%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #78   +/-   ##
=======================================
  Coverage   97.98%   97.99%           
=======================================
  Files          11       11           
  Lines         795      798    +3     
=======================================
+ Hits          779      782    +3     
  Misses         16       16           
Files Changed Coverage Δ
api/index.py 94.15% <100.00%> (+0.03%) ⬆️
api/utils/input_serializer.py 97.72% <100.00%> (+0.10%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

population, gdp_per_capita or forest area <br/> (in accordance with
the query type) with countries and years as columns. <br /><br />
population, gdp_per_capita or forest area <br />
(in accordance with the query type) with countries and years as
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this because of prettify ?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, prettier

.pylintrc Outdated
@@ -1,4 +1,4 @@
[MASTER]

[MESSAGES CONTROL]
disable = C0114, C0115, C0116, R0903
disable = C0114, C0115, C0116, R0903
Copy link
Owner Author

@Aritra8438 Aritra8438 Aug 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What has changed here?

If unwanted, remove it and then merge.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing was changed. I added W0611 and then removed.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then why git diff is showing changes?
Maybe you have added a new line? Can you remove it?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I didn't add a new line.

Signed-off-by: Aritra Majumder <[email protected]>
@raisachatterjee raisachatterjee merged commit a366d31 into main Aug 17, 2023
10 of 11 checks passed
@raisachatterjee raisachatterjee deleted the fix-input-errors branch August 17, 2023 07:08
@Aritra8438 Aritra8438 restored the fix-input-errors branch May 30, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants