fix(hub): clear parser-owned session key bytes - #313
Merged
gnanirahulnutakki merged 1 commit intoJul 23, 2026
Conversation
Copy the validated Ed25519 key into runtime-owned memory, then clear the parser-owned allocation before returning. Lock the ownership transfer with a focused non-aliasing and signing regression. GSTACK-Checkpoint: 2026-07-22/e3-session-key-lifetime#1 Signed-off-by: Gnani Rahul Nutakki <gnani.nutakki@gmail.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #310.
Part of #21.
Verification
go test -race -count=100 ./internal/hubruntime -run ^TestCopyAndClearSessionPrivateKeyTransfersOwnership$make cion exact rebased source with pinned golangci-lint v2.12.2, govulncheck v1.6.0, and checksum-verified promtool v3.13.1f3eac6b86f402495f5f31b478d41fa1761f979eeSecurity and cost
This narrows the lifetime of one redundant parser-owned signing-key copy. It is defense in depth, not a guarantee that every compiler/runtime copy is erased. It changes no IAM, network path, deployment input, storage, telemetry, or recurring cost. README was reviewed; no operator-facing behavior changed, so no README update is warranted.