feat(remediation): define immutable Git source snapshot - #305
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
b066f16 to
9f39758
Compare
|
Independent local CodeRabbit review completed against exact head
R2/R4 remain advisory-only; this PR introduces no DesiredChange, policy/execution authority, I/O, persistence, mutation, or runtime wiring. |
Add the observed-only git-source-snapshot/v1 contract for one canonical repository file observation. Bind exact current bytes to their Git blob identity, one object format, stable source and subject identity, attached evidence, and a bounded validity interval. Keep DesiredChange, Brain and resolver wiring, authority, credentials, I/O, persistence, mutation, and execution structurally absent so R2/R4 remain advisory-only. GSTACK-Checkpoint: 2026-07-22/e14-git-source-snapshot#1 Signed-off-by: Gnani Rahul Nutakki <gnani.nutakki@gmail.com>
9f39758 to
142ddd1
Compare
Summary
git-source-snapshot/v1contract approved on E14Approved separation
This PR implements
GitSourceSnapshotfirst.DesiredChangeis deliberately absent and remains a later separately reviewed transformer/renderer. The snapshot is not wired into the existing resolver, Brain, PEP, connector runtime, or Hub. R2 and R4 remain advisory-only.Owner decision: #46 (comment)
Consistency and failure boundaries
blob <byte-count>\0<current-content>Versionand pureFreshnessProof
make ci: format, vet, zero-issue lint, current govulncheck, every race test, tooling policies, nine Prometheus rules, performance, binary E2E, buildmake e2e-isolation: PostgreSQL 18.4 plus two 50,000-execution tenant fuzzersmake release-check: dual reproducible four-platform builds, SPDX SBOMs, formula, amd64/arm64 OCI142ddd180c63a2a847f0db06dd4c35c1dd1bcc71Independent finding
A repeated isolation run exposed a pre-existing approval-expiry test fixture clock race. Production remains PostgreSQL-clock authoritative; the test-only repair is isolated in #304 and is not mixed into this snapshot PR.
Security and cost
This contract is pure and offline. It contains no desired bytes, PR metadata, handler binding, actor, intent, policy decision, approval, credential, endpoint, persistence, dispatch, mutation, or execution state. It adds no API request, egress, storage, cloud resource, telemetry cardinality, or recurring cost.
A later live adapter separately owns least-privilege contents-read credentials, GitHub rate limits, egress, and remote freshness.
Closes #303
Does not close #46 or F14.6.