feat(approvals): expire grants after ten minutes - #300
Merged
gnanirahulnutakki merged 1 commit intoJul 21, 2026
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Mint one immutable database-clock expiry for every new approval, enforce the half-open lifetime in the single-use consume update, and bind expiry into versioned audit evidence. Retain legacy rows fail closed, preserve mixed-format offline verification, and document the transactional migration and rolling-upgrade contract. GSTACK-Checkpoint: 2026-07-21/approval-grant-expiry#1 Signed-off-by: Gnani Rahul Nutakki <gnani.nutakki@gmail.com>
gnanirahulnutakki
force-pushed
the
gnanirahulnutakki/approval-expiry-20260721
branch
from
July 21, 2026 20:14
57ddcec to
a15cc45
Compare
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security and failure behavior
Rollout
Apply migration 0013 before format-3 writers. Upgrade verifier-capable instances before enabling approval traffic. Older writers fail closed because the new immutable columns have no permissive defaults. Sith currently exposes no supported runtime approval or dispatch API, so this ordering does not interrupt an existing write surface.
Verification
Closes #299
Tracks bounded F5.9b work under #23; it does not complete parent F5.9.