feat(connector): split wire and adapter versions - #289
Merged
gnanirahulnutakki merged 1 commit intoJul 19, 2026
Conversation
Separate structured framework wire compatibility from opaque adapter provenance. Negotiate the highest explicitly common version, fail closed on malformed or incompatible offers, and bound each offer to 32 entries. Document the accepted E12 boundary and cover it with unit, boundary, fuzz, race, isolation, reproducible-release, and pinned kind proof. GSTACK-Checkpoint: 2026-07-19/e12-wire-adapter-version-split#1 Signed-off-by: Gnani Rahul Nutakki <gnani.nutakki@gmail.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This was referenced Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
protocol_versionserialization and adapter provenance semanticsCloses #288.
Scope guard
This PR completes only the bounded F12.1a/F12.3a version seam. It does not complete #30 or E12. It adds no protobuf schema, generated code, gRPC dependency, subprocess, listener, discovery, credentials, network I/O, persistence migration, execution route, package, release, cluster mutation, or cloud resource.
Verification
go mod verifygovulncheckv1.6.0: no vulnerabilitiesmake ci: format, vet, lint, vulnerability, race, shell-policy, Prometheus rule, performance, binary end-to-end, and build gatesmake e2e-isolation: forced PostgreSQL RLS suites and two 50,000-execution fuzz targetsmake release-check: dual snapshot reproducibility, SBOMs, checksums, Homebrew formula, and multi-architecture OCI layoutSecurity, reliability, and cost
Negotiation cannot silently interpret opaque evidence provenance as transport compatibility. Invalid or ambiguous offers fail before registration or use, and peer-controlled version lists are bounded. The change adds no authority, listener, process, credential, telemetry cardinality, cloud resource, or recurring cost.
Review focus